Add yq script #36
Merged
Add yq script #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correct default dsci needed for correct application
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tonyxrmdavidson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tonyxrmdavidson
requested review from
dhirajsb,
rkubis and
a team
and removed request for
tarilabs and
nehachopra27
tarilabs
reviewed
Mar 28, 2024
| @@ -157,6 +158,7 @@ run_deployment_tests() { | |||
|
|
|||
| # Main function for orchestrating deployments | |||
| main() { | |||
| ./install_yq.sh | |||
There was a problem hiding this comment.
at line 32 in openshift-ci/scripts/install_yq.sh you "Call the function when the script is sourced".
you source it at line 9.
didn't understand why you need this one here?
There was a problem hiding this comment.
You are correct Matteo, changing it now.
There was a problem hiding this comment.
I think it might be easier to install yq via the openshift-ci deployment.
openshift-merge-bot
bot
merged commit 65cd8d8
into
opendatahub-io:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a bash script to test if YQ is installed and installs it if it isn't.