periodic sync upstream KF to midstream ODH #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubeflow#37) Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…low#38) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.62.0 to 1.62.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.62.0...v1.62.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* OAS: fixup ID -> Id in parameter names ... to preserve camelCase. Signed-off-by: Isabella Basso do Amaral <[email protected]> * fix REST api to use ModelVersionUpdate in PATCH method Signed-off-by: Matteo Mortari <[email protected]> * bump OAS version to v1alpha3 Signed-off-by: Isabella Basso do Amaral <[email protected]> --------- Signed-off-by: Isabella Basso do Amaral <[email protected]> Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
… /csi (kubeflow#40) Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This reverts commit aeeffc0.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tonyxrmdavidson
pushed a commit
to tonyxrmdavidson/model-registry
that referenced
this pull request
Mar 22, 2024
…endatahub-io#27) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.4...v1.9.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
tonyxrmdavidson
pushed a commit
to tonyxrmdavidson/model-registry
that referenced
this pull request
Mar 22, 2024
* build(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (opendatahub-io#27) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.4...v1.9.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add first draft of model registry kserve custom storage initializer (opendatahub-io#25) * Add first draft of model registry custom storage initializer Signed-off-by: Andrea Lamparelli <[email protected]> * Add documentation and get started guide Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> * fix: ensure consistency ns(omitted) for istio manifests (opendatahub-io#31) * fix: ensure consistency ns(omitted) for istio manifests Signed-off-by: Matteo Mortari <[email protected]> * add default ns to kustomization for consistency with manifests/kustomize/overlays/{db} kustomizations Signed-off-by: Matteo Mortari <[email protected]> --------- Signed-off-by: Matteo Mortari <[email protected]> * fix CVE-2024-21626 (opendatahub-io#34) see also: https://security.snyk.io/vuln/SNYK-GOLANG-GITHUBCOMCONTAINERDCONTAINERD-6219724 Signed-off-by: Matteo Mortari <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <[email protected]> Co-authored-by: Matteo Mortari <[email protected]>
rareddy
reviewed
Mar 25, 2024
| @@ -82,7 +82,7 @@ Then, in the same terminal where you exported `MR_HOSTNAME`, perform the followi | |||
|
|
|||
| ```bash | |||
| curl --silent -X 'POST' \ | |||
| "$MR_HOSTNAME/api/model_registry/v1alpha2/registered_models" \ | |||
| "$MR_HOSTNAME/api/model_registry/v1alpha3/registered_models" \ | |||
There was a problem hiding this comment.
I know that we want to be back-compatible, but we do not have yet any stable released versions should we be changing the version numbers this aggressively? may be not right issue to ask this question either :(
There was a problem hiding this comment.
I recommend that if there are any API changes we update the version number only once for the given release. I am sure you might be already doing that, just wanted to understand.
There was a problem hiding this comment.
Yes, we can avoid "releasing too often", at the same time I understood we wanted to be strict on bumping the version number for every breaking change nevertheless.
Here is the short-blanket: either we minimize releases keeping the number bumps, or we release as often as needed and we relax strictness on the backward incompatibility of the REST API number. my2c.
|
/lgtm |
openshift-merge-bot
bot
merged commit bb0a432
into
opendatahub-io:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
content:
by revert with e9167d9