Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove static AUTH_PROVIDER in istio.env to allow operator to set it at runtime #139

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

dhirajsb
Copy link
Contributor

@dhirajsb dhirajsb commented Oct 1, 2024

Description

Removed default value of AUTH_PROVIDER in istio.env

How Has This Been Tested?

Tested by creating sample MR using the updated istio.env locally

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@rareddy
Copy link
Contributor

rareddy commented Oct 1, 2024

Can you describe why we need this, do we need to push this downstream?

@dhirajsb
Copy link
Contributor Author

dhirajsb commented Oct 1, 2024

@rareddy since it is in the samples we don't need to push it to downstream. The auth provider name is different between odh and rhoai. But the name is actually passed along in an env variable from odh/rhods operator to MR operator.
So, leaving this property blank allows MR operator to automatically use the environment default.

@dhirajsb
Copy link
Contributor Author

dhirajsb commented Oct 1, 2024

@tonyxrmdavidson has already fixed this in QE ods-ci tests.

@dhirajsb dhirajsb merged commit 5fee736 into opendatahub-io:main Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants