Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-15875: chore(gha): enable verbose govulncheck output #456

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

jiridanek
Copy link
Member

https://issues.redhat.com/browse/RHOAIENG-15875

Description

Turns out that this "impacted but not vulnerable" prodsec thing is around to haunt us. This way we'll have full info from govulncheck so that we can better assess various reports.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Turns out that this "impacted but not vulnerable" prodsec thing is around to haunt us.
This way we'll have full info from govulncheck so that we can better assess various reports.
@jiridanek
Copy link
Member Author

/approve

Copy link

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9f065c7 into opendatahub-io:main Nov 15, 2024
9 checks passed
@shalberd
Copy link

very nice, great idea

@jiridanek jiridanek deleted the jd_show_all_vuln branch November 15, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants