Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-14552: Reapply "RHOAIENG-10827: feat(nbcs): update ose-oauth-proxy image digest reference from 4.8 to the latest 4.14 version (#388)" #439

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Nov 6, 2024

https://issues.redhat.com/browse/RHOAIENG-14552

Reverts #419 (which was itself a revert of #388, therefore this is a reapplication of the original PR)

We can do this after

is merged.

…oauth-proxy image digest reference from 4.8 to the latest 4.14 version (#388)""
@jiridanek jiridanek self-assigned this Nov 6, 2024
@jiridanek jiridanek changed the title Reapply "RHOAIENG-10827: feat(nbcs): update ose-oauth-proxy image digest reference from 4.8 to the latest 4.14 version (#388)" RHOAIENG-14552: Reapply "RHOAIENG-10827: feat(nbcs): update ose-oauth-proxy image digest reference from 4.8 to the latest 4.14 version (#388)" Nov 6, 2024
@atheo89 atheo89 added the lgtm label Nov 6, 2024
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks for bring this back 💯

Copy link

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 6, 2024
@jiridanek
Copy link
Member Author

/override ci/prow/odh-notebook-controller-e2e
https://issues.redhat.com/browse/RHOAIENG-15492

Copy link

openshift-ci bot commented Nov 6, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/odh-notebook-controller-e2e

In response to this:

/override ci/prow/odh-notebook-controller-e2e
https://issues.redhat.com/browse/RHOAIENG-15492

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit c210f7a into main Nov 6, 2024
18 of 20 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the revert-419-jd_revert_oauth_proxy_update branch November 6, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants