Sync v1.9-branch branch with main branch
#424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…put is missing a newline (opendatahub-io#411) In case that the source of the certificates doesn't contain newline, this will assure that at least one new line is between the concatenated certificates. In case that the new line in the source is present already, then there will be two new lines now, but it shouldn't be a problem as it shouldn't break anything for us. This fixes [1]. * [1] https://issues.redhat.com/browse/RHOAIENG-11895
|
/lgtm |
|
/lgtm |
|
Thank you all! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit c5d8c55
into
opendatahub-io:v1.9-branch
22 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a recreation of the jstourac#1 PR that was created by a GHA on my fork (synced the main and v1.9-branch branches with this repository before I triggered it on my own fork). As I don't have rights to run these workflows here, this is kind of a workaround.
🤖 This is an automated Pull Request created by
/.github/workflows/sync-branches-through-pr.yml.It merges all commits from
mainbranch intov1.9-branchbranch.sync__main__v1.9-branch__20241018071227branch after merging the changes.