Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Update odh and notebook-controller with image main-7986030 #416

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Oct 7, 2024

🤖 This is an automated Pull Request created by /.github/workflows/notebook-controller-images-updater.yaml.

Have been updated the following related files:

  • components/notebook-controller/config/overlays/openshift/params.env
  • components/odh-notebook-controller/config/base/params.env
  • components/odh-notebook-controller/Makefile

Copy link

openshift-ci bot commented Oct 7, 2024

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89
Copy link
Member

atheo89 commented Oct 7, 2024

I believe this PR should be regularly opened to ensure alignment between the main branch and the ODH nightlies

/ok-to-test
/lgtm

@jiridanek
Copy link
Member

/lgtm

@jstourac
Copy link
Member

jstourac commented Oct 7, 2024

I believe this PR should be regularly opened to ensure alignment between the main branch and the ODH nightlies

I agree, ideally on nightly basis.

Copy link

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cba3e5d into main Oct 7, 2024
7 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the temp-11211801603 branch October 7, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants