RHOAIENG-9824: gha(odh-nbc): improve the GitHub Actions integration test for odh-notebook-controller to start the controller successfully and run a notebook #398
Conversation
|
/cherrypick stable |
|
@jiridanek: once the present PR merges, I will cherry-pick it on top of stable in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick v1.9-branch |
|
@jiridanek: once the present PR merges, I will cherry-pick it on top of v1.9-branch in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
@jiridanek: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Doesn't this need a rebase? This seems to contain changes that should be on the branch already (the oauth proxy image)? 🤔 |
|
Also, shouldn't we aim against |
…est for odh-notebook-controller to start the controller successfully and run a notebook
jiridanek
force-pushed
the
jd_test_notebook
branch
from
443b304
to
b63c035
Compare
done
dunno, I changed the PR target to main |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jiridanek: new pull request created: #401 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jiridanek: new pull request created: #402 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://issues.redhat.com/browse/RHOAIENG-9824
Description
Previously, the test was of a questionable value, because even normally, the operator was unable to initialize itself in upstream kubernetes (kind). Now the initialization is successful and a notebook is started.
How Has This Been Tested?
Run GHA
Merge criteria: