Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create gha to update automaticaly the notebook-controller images #371

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Jul 23, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-9848

Include a gha to update automatically the {odh}-notebook images

Description

How Has This Been Tested?

Tested locally: https://github.com/atheo89/kubeflow/actions/runs/10061493657/job/27811697276
It creates an automated PR : atheo89#2

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from jstourac and paulovmr July 23, 2024 15:22
@atheo89 atheo89 changed the title Create gha to update automaticaly the notebook-controller image Create gha to update automaticaly the notebook-controller images Jul 23, 2024
@jiridanek
Copy link
Member

/lgtm

@atheo89
Copy link
Member Author

atheo89 commented Jul 24, 2024

/retest-required

Include a gha to update automaticaly the notebook images
Copy link

openshift-ci bot commented Jul 24, 2024

New changes are detected. LGTM label has been removed.

@jiridanek jiridanek added the lgtm label Jul 24, 2024
@harshad16
Copy link
Member

/lgtm
/approve

thanks 💯

@harshad16 harshad16 merged commit 8a9b65a into opendatahub-io:v1.7-branch Jul 26, 2024
6 of 9 checks passed
Copy link

openshift-ci bot commented Jul 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants