Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the x/net package v0.23.0 for the cve fix #369

Merged

Conversation

harshad16
Copy link
Member

Description

Upgrade the x/net package v0.23.0 for the CVE fix.

Related-to: https://issues.redhat.com/browse/RHOAIENG-3621
Fixes: https://www.cve.org/CVERecord?id=CVE-2023-45288

How Has This Been Tested?

  • Use the CI tests.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and paulovmr July 22, 2024 17:31
@harshad16
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Do not merge this PR label Jul 22, 2024
@atheo89
Copy link
Member

atheo89 commented Jul 23, 2024

/retest-required

@atheo89
Copy link
Member

atheo89 commented Jul 23, 2024

/lgtm

@jiridanek
Copy link
Member

/lgtm

@harshad16
Copy link
Member Author

Tested this additionally with following images:

quay.io/opendatahub/kubeflow-notebook-controller:pr-369
quay.io/opendatahub/odh-notebook-controller:pr-369

Thanks for the reviews.
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Do not merge this PR label Jul 30, 2024
@harshad16
Copy link
Member Author

Based on the reviews and testing .
Approving this:
/approve

Copy link

openshift-ci bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit db3b994 into opendatahub-io:v1.7-branch Jul 30, 2024
15 checks passed
@jiridanek
Copy link
Member

/cherrypick stable

@openshift-cherrypick-robot

@jiridanek: new pull request created: #378

In response to this:

/cherrypick stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants