Change log from error to info

[atheo89]

This is a follow up enhancement to cover this discussion: #329 (comment)

Related to: https://issues.redhat.com/browse/RHOAIENG-8232

How Has This Been Tested?

Replace the odh-notebook-controller deployment with the following image: quay.io/rh_ee_atheodor/odh-notebook-controller:log-info2

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[jstourac]

Is this supposed to be a complete fix for https://issues.redhat.com/browse/RHOAIENG-8232 or is this just some preliminary partial fix until we know what all we want to do here? I am asking also whether we should put this issue in the commit message to be grabbed by errata or not.

[jiridanek]

/test all

[jstourac]

Since we have a followup issue to track to improve the implementation for the namespace and imagestreams lookup (https://issues.redhat.com/browse/RHOAIENG-8390), I am okay with this as is for now.

[jiridanek]

let's try something

/approve

[jiridanek]

/approve cancel

[harshad16]

Thanks for all the review
/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jiridanek, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [harshad16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[harshad16]

/cherrypick stable

[openshift-cherrypick-robot]

@harshad16: new pull request created: #355

In response to this:

/cherrypick stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[shalberd]

Since we have a followup issue to track to improve the implementation for the namespace and imagestreams lookup (https://issues.redhat.com/browse/RHOAIENG-8390), I am okay with this as is for now.

yeah, this should be an easy fix, see comment at https://issues.redhat.com/browse/RHOAIENG-8390

something akin to this (thanks, Github Copilot ...)

package main
 
import (
	"fmt"
	"os"
 
	"k8s.io/client-go/rest"
)
 
func getControllerNamespace() (string, error) {
	// Check if running inside a Kubernetes cluster
	if _, err := rest.InClusterConfig(); err != nil {
		return "", fmt.Errorf("not running inside a Kubernetes cluster")
	}
 
	// Try to get the namespace from the service account secret
	if data, err := os.ReadFile("/var/run/secrets/kubernetes.io/serviceaccount/namespace"); err == nil {
		if ns := string(data); len(ns) > 0 {
			return ns, nil
		}
	}
 
	return "", fmt.Errorf("unable to determine the namespace")
}
 
func main() {
	namespace, err := getControllerNamespace()
	if err != nil {
		fmt.Printf("Error: %v\n", err)
		return
	}
	fmt.Printf("Controller is running in namespace: %s\n", namespace)
}