Add logout-url to OAuthProxy container #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelvl
suggested changes
Jul 26, 2022
There was a problem hiding this comment.
Thanks for the PR @VaishnaviHire!
Can you add this annotation to existing unit tests to verify there are no regressions?
VaishnaviHire
force-pushed
the
add_logout_url
branch
from
260042f
to
b531b44
Compare
samuelvl
approved these changes
Jul 27, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: samuelvl, VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-robot
pushed a commit
to opendatahub-io/odh-manifests
that referenced
this pull request
Jul 27, 2022
harshad16
added a commit
to harshad16/odh-kubeflow
that referenced
this pull request
Oct 25, 2023
[master] Sync ODH stable branch change to RHODS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds
--logout-urlflag to the OAuthProxy container given thatnotebooks.opendatahub.io/oauth-logout-urlis set.Related to opendatahub-io/odh-dashboard#305 (comment)