Remove skip-provider-button flag from oauth configs #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atheo89
force-pushed
the
remove-skip-provider-button-from-oauth
branch
from
90cb257
to
fb769e5
Compare
atheo89
changed the title
|
/cc @harshad16 |
openshift-ci
bot
requested review from
harshad16
and removed request for
LaVLaS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the #109 issue of encountering an "infinite" login screen following the redirection of the unauthorized 403 page, as illustrated in the .gif below.
By removing the --skip-provider-button from the OAuth configurations. Consequently, after the redirection, users are able to be directed to the desired route path of the notebook.
However, on the route is missing
/notebook/${nb_namespace}/${nb_name}suffix, which is added by the dashboard when a user access a notebook from the dashboard.The route is unable to redirect from
/->/notebook/${nb_namespace}/${nb_name}, resulting in users encountering the JupyterLab 404 page, as shown below. Therefore, the user needs to manually press the Jupyter icon to be redirected to their notebook.A separate issue is tracking the work for the redirection #150
Merge criteria: