Merge pull request #386 from Jooho/change_protocol

set protocol https for .Status.Address.URL
opendatahub-io · Jul 18, 2024 · 26f2eb1 · 26f2eb1
2 parents 4259287 + 6bacfbf
commit 26f2eb1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/controller/v1beta1/inferenceservice/controller_test.go b/pkg/controller/v1beta1/inferenceservice/controller_test.go
@@ -1871,7 +1871,7 @@ var _ = Describe("v1beta1 inference service controller", func() {
 				Host:   constants.InferenceServiceHostName(constants.PredictorServiceName(serviceKey.Name), serviceKey.Namespace, domain),
 			}))
 			Expect(actualIsvc.Status.Address.URL).To(gomega.Equal(&apis.URL{
-				Scheme: "http",
+				Scheme: "https",
 				Host:   network.GetServiceHostname(fmt.Sprintf("%s-%s", serviceKey.Name, string(constants.Predictor)), serviceKey.Namespace),
 			}))
 		})

diff --git a/pkg/controller/v1beta1/inferenceservice/reconcilers/ingress/ingress_reconciler.go b/pkg/controller/v1beta1/inferenceservice/reconcilers/ingress/ingress_reconciler.go
@@ -611,7 +611,7 @@ func (ir *IngressReconciler) Reconcile(isvc *v1beta1.InferenceService) error {
 		isvc.Status.Address = &duckv1.Addressable{
 			URL: &apis.URL{
 				Host:   network.GetServiceHostname(hostPrefix, isvc.Namespace),
-				Scheme: "http",
+				Scheme: "https",
 			},
 		}
 		isvc.Status.SetCondition(v1beta1.IngressReady, &apis.Condition{