You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although this PR has many changes, this is not a refactoring. It is only meant to replace any with the expected types. It will help to have a safer code for future bug fixes, new features, and refactorings. After this PR, any unexplained attempt to use any will break the build.
A green CI is a good indication that everything is ok, however, a few changes were necessary to be incorporated to work with the types, especially null checks.
Notebook-based images to use for tests (commit 431c88e):
Refactoring is a controlled technique for improving the design of an existing code base. Its essence is applying a series of small behavior-preserving transformations, each of which “too small to be worth doing”. However the cumulative effect of each of these transformations is quite significant. By doing them in small steps you reduce the risk of introducing errors. You also avoid having the system broken while you are carrying out the restructuring - which allows you to gradually refactor a system over an extended period of time. (https://martinfowler.com/books/refactoring.html)
Adding types in typescript sure is behavior preserving.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-14040
Although this PR has many changes, this is not a refactoring. It is only meant to replace
anywith the expected types. It will help to have a safer code for future bug fixes, new features, and refactorings. After this PR, any unexplained attempt to useanywill break the build.A green CI is a good indication that everything is ok, however, a few changes were necessary to be incorporated to work with the types, especially null checks.
Notebook-based images to use for tests (commit 431c88e):