fix(backend): Fix a bug in ListArtifacts and GetArtifacts with older releases #82

rimolive · 2024-10-09T19:49:00Z

This bug was introduced after kfp 2.2.0 code rebase

Description of your changes:

Checklist:

The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

dsp-developers · 2024-10-09T19:50:00Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
ERROR: couldn't find commits from 028d903889f2de5d7e0ac27be001f9523a3a126e..0bd1abd181f118d31cb12ae892b0bb9415e11a73: error executing git log: fatal: Invalid revision range 028d903889f2de5d7e0ac27be001f9523a3a126e..0bd1abd181f118d31cb12ae892b0bb9415e11a73
: exit status 128

dsp-developers · 2024-10-09T19:50:34Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 028d903889f2de5d7e0ac27be001f9523a3a126e...32156258453e3309974362da3bac6ccb301988cb

UPSTREAM commit 3215625 has invalid summary Fix a bug ListArtifacts and Getartifacts with older rhoai releases.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-10-09T19:59:34Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-82
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-82
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-82
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-82
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-82
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-82

backend/src/apiserver/resource/resource_manager.go

dsp-developers · 2024-10-10T15:28:35Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 028d903889f2de5d7e0ac27be001f9523a3a126e...50a5a44b2a54659c351d825763d92dfcd7a0a4d9

dsp-developers · 2024-10-10T15:37:39Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-82
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-82
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-82
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-82
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-82
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-82

dsp-developers · 2024-10-10T18:29:19Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 028d903889f2de5d7e0ac27be001f9523a3a126e...7ccd7de92a18dbfbf54a8d8736dd756bd5d2525e

dsp-developers · 2024-10-10T18:38:49Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-82
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-82
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-82
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-82
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-82
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-82

dsp-developers · 2024-10-11T18:38:48Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between af760e3d073519c8cc7f1791950ac0c39c26b739...a175ecfb241bd7f9b3b29841d12613f286d7f190

dsp-developers · 2024-10-11T18:48:07Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-82
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-82
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-82
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-82
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-82
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-82

dsp-developers · 2024-10-14T19:58:18Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between af760e3d073519c8cc7f1791950ac0c39c26b739...66275b6e4922e9e9fd8d7b86ce8cc9c827e1cae0

dsp-developers · 2024-10-14T20:07:25Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-82
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-82
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-82
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-82
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-82
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-82

backend/src/apiserver/resource/resource_manager.go

dsp-developers · 2024-10-15T18:12:55Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between af760e3d073519c8cc7f1791950ac0c39c26b739...8c3527b39908fd07b92f5e64fc9e23e7a8128ff7

dsp-developers · 2024-10-15T18:22:10Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-82
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-82
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-82
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-82
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-82
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-82

backend/src/apiserver/resource/resource_manager.go

dsp-developers · 2024-10-16T11:05:16Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between af760e3d073519c8cc7f1791950ac0c39c26b739...06aad1a164ace5613de374e295f8bc868990813e

dsp-developers · 2024-10-16T11:14:03Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-82
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-82
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-82
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-82
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-82
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-82

diegolovison

I think we should remove the commented code

backend/src/apiserver/resource/resource_manager_test.go

…r rhoai releases This bug was introduced after kfp 2.2.0 code rebase Signed-off-by: Ricardo M. Oliveira <[email protected]>

dsp-developers · 2024-10-16T13:40:43Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between af760e3d073519c8cc7f1791950ac0c39c26b739...c835190308b03766071e26a8eccff1b5dfedeceb

diegolovison · 2024-10-16T13:42:42Z

/lgtm

dsp-developers · 2024-10-16T13:50:30Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-82
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-82
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-82
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-82
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-82
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-82

HumairAK · 2024-10-16T14:12:04Z

/lgtm

HumairAK · 2024-10-16T14:13:53Z

/approve

openshift-ci · 2024-10-16T14:15:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [HumairAK]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dsp-developers · 2024-10-16T14:19:03Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 50c48697c3c70d23afd0694b398076c6068098af...c835190308b03766071e26a8eccff1b5dfedeceb

openshift-ci bot requested review from gmfrasca and gregsheremeta October 9, 2024 19:49

rimolive force-pushed the rmartine-keep-rebasing branch from 0bd1abd to 3215625 Compare October 9, 2024 19:49

rimolive changed the title ~~fix(backend): Fix a bug ListArtifacts and Getartifacts with older rhoai releases~~ fix(backend): Fix a bug in ListArtifacts and GetArtifacts with older rhoai releases Oct 9, 2024

rimolive changed the title ~~fix(backend): Fix a bug in ListArtifacts and GetArtifacts with older rhoai releases~~ fix(backend): Fix a bug in ListArtifacts and GetArtifacts with older releases Oct 9, 2024

HumairAK reviewed Oct 9, 2024

View reviewed changes

backend/src/apiserver/resource/resource_manager.go Outdated Show resolved Hide resolved

rimolive force-pushed the rmartine-keep-rebasing branch from 3215625 to 50a5a44 Compare October 10, 2024 15:27

rimolive force-pushed the rmartine-keep-rebasing branch from 50a5a44 to 7ccd7de Compare October 10, 2024 18:28

rimolive force-pushed the rmartine-keep-rebasing branch from a175ecf to 66275b6 Compare October 14, 2024 19:57

diegolovison reviewed Oct 15, 2024

View reviewed changes

backend/src/apiserver/resource/resource_manager.go Show resolved Hide resolved

HumairAK reviewed Oct 15, 2024

View reviewed changes

backend/src/apiserver/resource/resource_manager.go Outdated Show resolved Hide resolved

rimolive force-pushed the rmartine-keep-rebasing branch from 66275b6 to 8c3527b Compare October 15, 2024 18:11

HumairAK reviewed Oct 15, 2024

View reviewed changes

backend/src/apiserver/resource/resource_manager.go Outdated Show resolved Hide resolved

rimolive force-pushed the rmartine-keep-rebasing branch from 8c3527b to 06aad1a Compare October 16, 2024 11:04

diegolovison reviewed Oct 16, 2024

View reviewed changes

backend/src/apiserver/resource/resource_manager_test.go Outdated Show resolved Hide resolved

backend/src/apiserver/resource/resource_manager_test.go Show resolved Hide resolved

HumairAK reviewed Oct 16, 2024

View reviewed changes

backend/src/apiserver/resource/resource_manager_test.go Outdated Show resolved Hide resolved

UPSTREAM: <carry>: Fix a bug ListArtifacts and Getartifacts with olde…

c835190

…r rhoai releases This bug was introduced after kfp 2.2.0 code rebase Signed-off-by: Ricardo M. Oliveira <[email protected]>

rimolive force-pushed the rmartine-keep-rebasing branch from 06aad1a to c835190 Compare October 16, 2024 13:39

openshift-ci bot assigned diegolovison Oct 16, 2024

openshift-ci bot added the lgtm label Oct 16, 2024

openshift-ci bot assigned HumairAK Oct 16, 2024

openshift-ci bot added the approved label Oct 16, 2024

HumairAK approved these changes Oct 16, 2024

View reviewed changes

HumairAK merged commit 50c4869 into opendatahub-io:master Oct 16, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(backend): Fix a bug in ListArtifacts and GetArtifacts with older releases #82

fix(backend): Fix a bug in ListArtifacts and GetArtifacts with older releases #82

rimolive commented Oct 9, 2024

dsp-developers commented Oct 9, 2024

dsp-developers commented Oct 9, 2024

dsp-developers commented Oct 9, 2024

dsp-developers commented Oct 10, 2024

dsp-developers commented Oct 10, 2024

dsp-developers commented Oct 10, 2024

dsp-developers commented Oct 10, 2024

dsp-developers commented Oct 11, 2024

dsp-developers commented Oct 11, 2024

dsp-developers commented Oct 14, 2024

dsp-developers commented Oct 14, 2024

dsp-developers commented Oct 15, 2024

dsp-developers commented Oct 15, 2024

dsp-developers commented Oct 16, 2024

dsp-developers commented Oct 16, 2024

diegolovison left a comment

dsp-developers commented Oct 16, 2024

diegolovison commented Oct 16, 2024

dsp-developers commented Oct 16, 2024

HumairAK commented Oct 16, 2024

HumairAK commented Oct 16, 2024

openshift-ci bot commented Oct 16, 2024

dsp-developers commented Oct 16, 2024

fix(backend): Fix a bug in ListArtifacts and GetArtifacts with older releases #82

fix(backend): Fix a bug in ListArtifacts and GetArtifacts with older releases #82

Conversation

rimolive commented Oct 9, 2024

dsp-developers commented Oct 9, 2024

Commit Checker results:

dsp-developers commented Oct 9, 2024

Commit Checker results:

dsp-developers commented Oct 9, 2024

dsp-developers commented Oct 10, 2024

Commit Checker results:

dsp-developers commented Oct 10, 2024

dsp-developers commented Oct 10, 2024

Commit Checker results:

dsp-developers commented Oct 10, 2024

dsp-developers commented Oct 11, 2024

Commit Checker results:

dsp-developers commented Oct 11, 2024

dsp-developers commented Oct 14, 2024

Commit Checker results:

dsp-developers commented Oct 14, 2024

dsp-developers commented Oct 15, 2024

Commit Checker results:

dsp-developers commented Oct 15, 2024

dsp-developers commented Oct 16, 2024

Commit Checker results:

dsp-developers commented Oct 16, 2024

diegolovison left a comment

Choose a reason for hiding this comment

dsp-developers commented Oct 16, 2024

Commit Checker results:

diegolovison commented Oct 16, 2024

dsp-developers commented Oct 16, 2024

HumairAK commented Oct 16, 2024

HumairAK commented Oct 16, 2024

openshift-ci bot commented Oct 16, 2024

dsp-developers commented Oct 16, 2024

Commit Checker results: