UPSTREAM: <carry>: Bump github.com/argoproj/argo-workflows/v3 from v3.3.10 to v3.5.8 #58

hbelmiro · 2024-06-25T19:19:34Z

Description of your changes:
Fixes the github.com/satori/go.uuid CVE from https://issues.redhat.com/browse/RHOAIENG-8495.

Checklist:

The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

dsp-developers · 2024-06-25T19:20:39Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between dadfb38393ce96cb7dc1eac60428d66f0e3f1933...98295f35769bb41530c8889a56752119b205aa53

UPSTREAM commit 98295f3 has invalid summary Bump github.com/argoproj/argo-workflows/v3 from v3.3.10 to v3.5.8.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-06-25T19:39:46Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between dadfb38393ce96cb7dc1eac60428d66f0e3f1933...cfaec1f5ac30aff94975018e9728a7453cf756fc

UPSTREAM commit cfaec1f has invalid summary Bump github.com/argoproj/argo-workflows/v3 from v3.3.10 to v3.5.8.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-06-25T19:48:55Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-58
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-58
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-58
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-58
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-58
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-58

dsp-developers · 2024-06-25T20:31:23Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between dadfb38393ce96cb7dc1eac60428d66f0e3f1933...8e1d7ac69575df507d03f5e38cd8fc93f6230942

UPSTREAM commit 8e1d7ac has invalid summary Bump github.com/argoproj/argo-workflows/v3 from v3.3.10 to v3.5.8.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-06-25T20:40:20Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-58
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-58
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-58
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-58
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-58
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-58

dsp-developers · 2024-06-25T21:09:10Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between dadfb38393ce96cb7dc1eac60428d66f0e3f1933...228cda290ecc41f254074709e83421aecb6e3943

UPSTREAM commit 228cda2 has invalid summary Bump github.com/argoproj/argo-workflows/v3 from v3.3.10 to v3.5.8.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-06-25T21:18:37Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-58
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-58
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-58
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-58
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-58
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-58

hbelmiro · 2024-06-26T12:37:08Z

cc @DharmitD

rimolive · 2024-06-26T13:45:30Z

@hbelmiro Please follow the suggestions from commit checker comments.

….3.10 to v3.5.8 Signed-off-by: hbelmiro <[email protected]>

dsp-developers · 2024-06-26T18:17:35Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between dadfb38393ce96cb7dc1eac60428d66f0e3f1933...38ce527bd570d2297f8497353944c813655571c2

dsp-developers · 2024-06-26T18:26:41Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-58
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-58
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-58
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-58
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-58
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-58

hbelmiro · 2024-06-26T18:28:36Z

@hbelmiro Please follow the suggestions from commit checker comments.

@rimolive fixed.

backend/src/apiserver/template/argo_template.go

DharmitD · 2024-06-26T19:44:07Z

go.mod/go.sum and licenses' updates lgtm, I'll let @gmfrasca / @hbelmiro look at argo related code changes, and approve.

DharmitD

Package and code changes

/lgtm

@gmfrasca @HumairAK could you make sure to check the argo code changes once before approving? Ty!

gregsheremeta

/lgtm

backend/src/apiserver/template/argo_template.go

gregsheremeta · 2024-06-28T14:48:13Z

/approve

openshift-ci · 2024-06-28T14:48:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gregsheremeta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gregsheremeta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dsp-developers · 2024-06-28T14:52:22Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 4a147666f16dfabfa49f7574fe604a5364fc5035...38ce527bd570d2297f8497353944c813655571c2

openshift-ci bot added the do-not-merge/work-in-progress label Jun 25, 2024

hbelmiro force-pushed the RHOAIENG-8495 branch from 98295f3 to cfaec1f Compare June 25, 2024 19:38

hbelmiro changed the title ~~WIP - Bump github.com/argoproj/argo-workflows/v3 from v3.3.10 to v3.5.8~~ UPSTREAM: <carry>: Bump github.com/argoproj/argo-workflows/v3 from v3.3.10 to v3.5.8 Jun 25, 2024

hbelmiro force-pushed the RHOAIENG-8495 branch from cfaec1f to 8e1d7ac Compare June 25, 2024 20:30

hbelmiro force-pushed the RHOAIENG-8495 branch from 8e1d7ac to 228cda2 Compare June 25, 2024 21:08

hbelmiro marked this pull request as ready for review June 26, 2024 12:36

openshift-ci bot removed the do-not-merge/work-in-progress label Jun 26, 2024

openshift-ci bot requested review from rimolive and VaniHaripriya June 26, 2024 12:36

UPSTREAM: <carry>: Bump github.com/argoproj/argo-workflows/v3 from v3…

38ce527

….3.10 to v3.5.8 Signed-off-by: hbelmiro <[email protected]>

hbelmiro force-pushed the RHOAIENG-8495 branch from 228cda2 to 38ce527 Compare June 26, 2024 18:16

DharmitD reviewed Jun 26, 2024

View reviewed changes

backend/src/apiserver/template/argo_template.go Show resolved Hide resolved

DharmitD reviewed Jun 28, 2024

View reviewed changes

openshift-ci bot assigned DharmitD Jun 28, 2024

openshift-ci bot added the lgtm label Jun 28, 2024

gregsheremeta reviewed Jun 28, 2024

View reviewed changes

backend/src/apiserver/template/argo_template.go Show resolved Hide resolved

openshift-ci bot assigned gregsheremeta Jun 28, 2024

openshift-ci bot added the approved label Jun 28, 2024

openshift-merge-bot bot merged commit 4a14766 into opendatahub-io:master Jun 28, 2024
3 checks passed

hbelmiro deleted the RHOAIENG-8495 branch June 28, 2024 15:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UPSTREAM: <carry>: Bump github.com/argoproj/argo-workflows/v3 from v3.3.10 to v3.5.8 #58

UPSTREAM: <carry>: Bump github.com/argoproj/argo-workflows/v3 from v3.3.10 to v3.5.8 #58

hbelmiro commented Jun 25, 2024 •

edited

Loading

dsp-developers commented Jun 25, 2024

dsp-developers commented Jun 25, 2024

dsp-developers commented Jun 25, 2024

dsp-developers commented Jun 25, 2024

dsp-developers commented Jun 25, 2024

dsp-developers commented Jun 25, 2024

dsp-developers commented Jun 25, 2024

hbelmiro commented Jun 26, 2024

rimolive commented Jun 26, 2024

dsp-developers commented Jun 26, 2024

dsp-developers commented Jun 26, 2024

hbelmiro commented Jun 26, 2024

DharmitD commented Jun 26, 2024

DharmitD left a comment

gregsheremeta left a comment

gregsheremeta commented Jun 28, 2024

openshift-ci bot commented Jun 28, 2024

dsp-developers commented Jun 28, 2024

UPSTREAM: <carry>: Bump github.com/argoproj/argo-workflows/v3 from v3.3.10 to v3.5.8 #58

UPSTREAM: <carry>: Bump github.com/argoproj/argo-workflows/v3 from v3.3.10 to v3.5.8 #58

Conversation

hbelmiro commented Jun 25, 2024 • edited Loading

dsp-developers commented Jun 25, 2024

Commit Checker results:

dsp-developers commented Jun 25, 2024

Commit Checker results:

dsp-developers commented Jun 25, 2024

dsp-developers commented Jun 25, 2024

Commit Checker results:

dsp-developers commented Jun 25, 2024

dsp-developers commented Jun 25, 2024

Commit Checker results:

dsp-developers commented Jun 25, 2024

hbelmiro commented Jun 26, 2024

rimolive commented Jun 26, 2024

dsp-developers commented Jun 26, 2024

Commit Checker results:

dsp-developers commented Jun 26, 2024

hbelmiro commented Jun 26, 2024

DharmitD commented Jun 26, 2024

DharmitD left a comment

Choose a reason for hiding this comment

gregsheremeta left a comment

Choose a reason for hiding this comment

gregsheremeta commented Jun 28, 2024

openshift-ci bot commented Jun 28, 2024

dsp-developers commented Jun 28, 2024

Commit Checker results:

hbelmiro commented Jun 25, 2024 •

edited

Loading