UPSTREAM: <carry>: Upgrade DSP go.mod package versions #55
Conversation
Commit Checker results: |
|
A set of new images have been built to help with testing out this PR: |
|
An OCP cluster where you are logged in as cluster admin is required. The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO. To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
name: pr-55
spec:
dspVersion: v2
apiServer:
image: "quay.io/opendatahub/ds-pipelines-api-server:pr-55"
argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-55"
argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-55"
persistenceAgent:
image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-55"
scheduledWorkflow:
image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-55"
mlmd:
deploy: true # Optional component
grpc:
image: "quay.io/opendatahub/mlmd-grpc-server:latest"
envoy:
image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
mlpipelineUI:
deploy: true # Optional component
image: "quay.io/opendatahub/ds-pipelines-frontend:pr-55"
objectStorage:
minio:
deploy: true
image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'Then run the following: cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/55/head
git checkout -b pullrequest 132a1b97347c990ecd4b89233951b7308ad2d46f
oc apply -f dspa.pr-55.yamlMore instructions here on how to deploy and test a Data Science Pipelines Application. |
DharmitD
changed the title
Commit Checker results: |
|
Change to PR detected. A new PR build was completed. |
go.mod
Outdated
| github.com/stretchr/testify v1.8.4 | ||
| gocloud.dev v0.22.0 | ||
| golang.org/x/net v0.19.0 | ||
| golang.org/x/net v0.21.0 |
There was a problem hiding this comment.
can we not change this to v0.23.0 instead of having a replace directive here?
There was a problem hiding this comment.
Done, updated to have this change.
| @@ -4,12 +4,12 @@ require ( | |||
| github.com/Masterminds/squirrel v0.0.0-20190107164353-fa735ea14f09 | |||
| github.com/VividCortex/mysqlerr v0.0.0-20170204212430-6c6b55f8796f | |||
| github.com/argoproj/argo-workflows/v3 v3.3.10 | |||
| github.com/aws/aws-sdk-go v1.42.50 | |||
There was a problem hiding this comment.
since you updated go.mod, you'll need to update the license CSVs. you can do that by simply running make all in backend/
Commit Checker results: |
Commit Checker results: |
|
Change to PR detected. A new PR build was completed. |
1 similar comment
|
Change to PR detected. A new PR build was completed. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amadhusu, HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Commit Checker results: |
Description of your changes:
resolves: https://issues.redhat.com/browse/RHOAIENG-7308
Implemented fixes on my fork, tested them out by importing the fork in my personal snyk account and making sure the CVEs were eliminated. Refer to commits on my fork here if you want to analyze fixes for each individual CVE.
Checklist: