-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: <carry>: Upgrade DSP api/go.mod package versions #54
Conversation
Commit Checker results:
|
A set of new images have been built to help with testing out this PR: |
An OCP cluster where you are logged in as cluster admin is required. The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO. To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
name: pr-54
spec:
dspVersion: v2
apiServer:
image: "quay.io/opendatahub/ds-pipelines-api-server:pr-54"
argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-54"
argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-54"
persistenceAgent:
image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-54"
scheduledWorkflow:
image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-54"
mlmd:
deploy: true # Optional component
grpc:
image: "quay.io/opendatahub/mlmd-grpc-server:latest"
envoy:
image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
mlpipelineUI:
deploy: true # Optional component
image: "quay.io/opendatahub/ds-pipelines-frontend:pr-54"
objectStorage:
minio:
deploy: true
image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance' Then run the following: cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/54/head
git checkout -b pullrequest 2bf529fe091b2bcb589e7ed90990fec428ba6fd4
oc apply -f dspa.pr-54.yaml More instructions here on how to deploy and test a Data Science Pipelines Application. |
Commit Checker results:
|
Change to PR detected. A new PR build was completed. |
@@ -10,5 +10,6 @@ require ( | |||
replace ( | |||
github.com/mattn/go-sqlite3 => github.com/mattn/go-sqlite3 v1.14.18 | |||
golang.org/x/net => golang.org/x/net v0.17.0 | |||
golang.org/x/net v0.17.0 => golang.org/x/net v0.23.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this not just reduce the above line down to
golang.org/x/net => golang.org/x/net v0.23.0
?
since you updated |
resolved this in #56 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amadhusu, HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Commit Checker results:
|
Description of your changes:
resolves: https://issues.redhat.com/browse/RHOAIENG-7308
Implemented fixes on my fork and tested out by importing the fork in my personal snyk account and making sure the CVEs were eliminated.
Checklist: