Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM:<carry>:chore:RHOAIENG-7423 - Updated ubi8 image and go-toolset version #44

Merged
merged 1 commit into from
May 30, 2024

Conversation

amadhusu
Copy link

Description of your changes:
Updated ubi8 image as suggested in RHOAIENG-7423

Testing instructions:
Sanity Tests

Checklist:

Copy link

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gregsheremeta for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers
Copy link

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-44
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-44
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-44
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-44
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-44
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-44

@dsp-developers
Copy link

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-44.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-44
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-44"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-44"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-44"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-44"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-44"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/mlmd-grpc-server:latest"
    envoy:
      image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-44"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/44/head
git checkout -b pullrequest ebb1b7d4d164dcb99fa5eeeeca1f65cd816301f4
oc apply -f dspa.pr-44.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

@HumairAK
Copy link

@amadhusu can you remove the jira id from the commit message?

@amadhusu
Copy link
Author

@amadhusu can you remove the jira id from the commit message?

Done

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
ERROR: couldn't find commits from 25f33aa..ea12783: error executing git log: fatal: Invalid revision range 25f33aa..ea12783
: exit status 128

@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-44
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-44
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-44
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-44
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-44
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-44

@HumairAK HumairAK merged commit effca01 into opendatahub-io:master May 30, 2024
2 of 3 checks passed
@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
ERROR: couldn't find commits from effca01..ea12783: error executing git log: fatal: Invalid revision range effca01..ea12783
: exit status 128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants