Merge pull request #59 from gregsheremeta/rename-UpdateLastRun

UPSTREAM: <carry>: chore(backend): Rename UpdateLastRun -> SetLastRunTimestamp
opendatahub-io · Jul 3, 2024 · b775d3c · b775d3c
2 parents ed99781 + 63b5a63
commit b775d3c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/backend/src/apiserver/resource/resource_manager.go b/backend/src/apiserver/resource/resource_manager.go
@@ -552,9 +552,9 @@ func (r *ResourceManager) CreateRun(ctx context.Context, run *model.Run) (*model
 	}
 
 	// Upon run creation, update owning experiment
-	err = r.experimentStore.UpdateLastRun(newRun)
+	err = r.experimentStore.SetLastRunTimestamp(newRun)
 	if err != nil {
-		return nil, util.Wrap(err, fmt.Sprintf("Failed to update last_run_created_at in experiment %s for run %s", newRun.ExperimentId, newRun.UUID))
+		return nil, util.Wrap(err, fmt.Sprintf("Failed to set last run timestamp on experiment %s for run %s", newRun.ExperimentId, newRun.UUID))
 	}
 
 	return newRun, nil
@@ -1264,7 +1264,7 @@ func (r *ResourceManager) ReportWorkflowResource(ctx context.Context, execSpec u
 			runId = run.UUID
 		}
 		// Upon run creation, update owning experiment
-		if updateError = r.experimentStore.UpdateLastRun(run); updateError != nil {
+		if updateError = r.experimentStore.SetLastRunTimestamp(run); updateError != nil {
 			return nil, util.Wrapf(updateError, "Failed to report a workflow for existing run %s during updating the owning experiment.", runId)
 		}
 	}

diff --git a/backend/src/apiserver/storage/experiment_store.go b/backend/src/apiserver/storage/experiment_store.go
@@ -33,7 +33,7 @@ type ExperimentStoreInterface interface {
 	ArchiveExperiment(expId string) error
 	UnarchiveExperiment(expId string) error
 	DeleteExperiment(uuid string) error
-	UpdateLastRun(run *model.Run) error
+	SetLastRunTimestamp(run *model.Run) error
 }
 
 type ExperimentStore struct {
@@ -419,9 +419,9 @@ func (s *ExperimentStore) UnarchiveExperiment(expId string) error {
 	return nil
 }
 
-func (s *ExperimentStore) UpdateLastRun(run *model.Run) error {
+func (s *ExperimentStore) SetLastRunTimestamp(run *model.Run) error {
 	expId := run.ExperimentId
-	// UpdateLastRun results in the experiment getting last_run_created_at updated
+	// SetLastRunTimestamp results in the experiment getting last_run_created_at updated
 	query, args, err := sq.
 		Update("experiments").
 		SetMap(sq.Eq{