Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: DSPv2 : Improve Logging in Data Science Pipelines pods #158

Closed
DharmitD opened this issue Oct 11, 2023 · 3 comments
Closed
Assignees
Labels
good first issue Good for newcomers kind/enhancement New feature or request priority/normal An issue with the product; fix when possible triage/accepted v2-integration

Comments

@DharmitD
Copy link
Member

Feature description

Every time we need to enable debug logging in DSP components (API Server, persistence agent, scheduled workflow), it is a pain to make it work. We need to enable logging through manifest parameters and inject through env var in all pods to enable debugging.

Related to https://github.com/opendatahub-io/data-science-pipelines/issues/148, except #148 addresses v1 and we need to replicate the same efforts for v2.

Describe alternatives you've considered

No response

Anything else?

No response

@DharmitD
Copy link
Member Author

This feature needs to go into upstream kubeflow/pipelines repo first. Find the related issue created here: kubeflow/pipelines#10105

Once a PR is merged upstream, we could cherry pick and create a PR to the midstream (odh/dsp) repo.

This PR could be used as a reference to make these changes upstream: https://github.com/opendatahub-io/data-science-pipelines/pull/160

@DharmitD
Copy link
Member Author

DharmitD commented Dec 7, 2023

Related upstream PR: kubeflow/pipelines#10288

@DharmitD DharmitD moved this from In Progress to In Review in deprecated - ODH Data Science Pipelines Planning Dec 11, 2023
@DharmitD
Copy link
Member Author

DharmitD commented Jan 5, 2024

Closing as the PR kubeflow/pipelines#10288 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement New feature or request priority/normal An issue with the product; fix when possible triage/accepted v2-integration
Projects
Status: Done
Status: No status
Development

No branches or pull requests

3 participants