Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Logging in Data Science Pipelines pods #148

Closed
rimolive opened this issue Oct 4, 2023 · 2 comments
Closed

Improve Logging in Data Science Pipelines pods #148

rimolive opened this issue Oct 4, 2023 · 2 comments
Assignees
Labels

Comments

@rimolive
Copy link

rimolive commented Oct 4, 2023

Every time we need to enable debug logging in DSP components (API Server, persistence agent, scheduled workflow), it is a pain to make it work. We need to enable logging through manifest parameters and inject through env var in all pods to enable debugging.

@DharmitD
Copy link
Member

The initial scope of the task was around just making manifest changes to our midstream repo. On further investigation, we figured that we would need to make changes to the code base as well (main.go for ever component), irrespective on whether we choose to use logrus or glog/klog packages for setting logging levels.

For example, Persistence Agent doesn't have the glog package imported: https://github.com/opendatahub-io/data-science-pipelines/blob/master/backend/src/agent/persistence/main.go#L26
We would need to import the package, and also add some code the way we've added in this PR, to make sure we have a log-level cli parameter, through which we could pass a value and set the variable for the desired log level.

Similarly, we would need to update the code base for APIServer and Scheduled Workflow components as well. Hence, this change needs to go into the upstream kfp-tekton repo first.

@DharmitD
Copy link
Member

Closing this task since this change needs to go into upstream first. Created #158 to address this for v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants