Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped actions/upload-artifact to v4 #701

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Sep 17, 2024

Description of your changes:

This PR updates upload-artifact action due to deprecation. The current version is blocking PRs.
Deprecation notice: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

Testing instructions

The Trigger build images for PRs / upload-data (pull_request) workflow should pass.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rimolive
Copy link
Contributor

/lgtm

@HumairAK
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@diegolovison
Copy link
Contributor

/lgmt

@HumairAK HumairAK merged commit 6cf02ac into opendatahub-io:main Sep 17, 2024
4 of 6 checks passed
@hbelmiro hbelmiro deleted the update-upload-artifact branch September 17, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants