Removed imagePullPolicy: IfNotPresent #697
Conversation
|
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/697/head
git checkout -b pullrequest a726e3c78652ad780457f1d96d282480634a6f0d
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-697"More instructions here on how to deploy and test a Data Science Pipelines Application. |
hbelmiro
force-pushed
the
remove-image-pull-policy
branch
from
a726e3c
to
edd8773
Compare
|
Change to PR detected. A new PR build was completed. |
| newName: quay.io/hbelmiro/dspo | ||
| newTag: dev-remove-image-pull-policy-1725475322 |
| @@ -55,7 +55,7 @@ spec: | |||
| ports: | |||
| - containerPort: 9000 | |||
| protocol: TCP | |||
| imagePullPolicy: IfNotPresent | |||
| # imagePullPolicy: default - https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting | |||
There was a problem hiding this comment.
can we also revisit existing imagepolicies, for example apiserver has it set to Always https://github.com/opendatahub-io/data-science-pipelines-operator/blob/main/config/internal/apiserver/default/deployment.yaml.tmpl#L179
we should be consistent across all pods
Signed-off-by: hbelmiro <[email protected]>
hbelmiro
force-pushed
the
remove-image-pull-policy
branch
from
edd8773
to
3f9f9ff
Compare
|
Change to PR detected. A new PR build was completed. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Resolves: https://issues.redhat.com/browse/RHOAIENG-12336
This PR changes
imagePullPolicyfor default instead ofIfNotPresent.Testing instructions
Deploy the
simple-dspasample and run the pipeline. The run must succeed.Checklist