Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image-check automation #167

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Add image-check automation #167

merged 1 commit into from
Jun 30, 2023

Conversation

rimolive
Copy link
Contributor

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from DharmitD and gregsheremeta June 15, 2023 18:26
@rimolive rimolive changed the title Add kube-linter automation [WIP] Add kube-linter automation Jun 15, 2023
@rimolive rimolive changed the title [WIP] Add kube-linter automation [WIP] Add image-check automation Jun 16, 2023
@rimolive rimolive mentioned this pull request Jun 19, 2023
Closed
DharmitD
DharmitD reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 23, 2023
@HumairAK
Copy link
Contributor

@rimolive can we update the images as part of this PR and confirm this ci check passes

@openshift-ci openshift-ci bot removed the lgtm label Jun 29, 2023
@HumairAK HumairAK changed the title [WIP] Add image-check automation Add image-check automation Jun 30, 2023
@HumairAK
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jun 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 70eab9e into opendatahub-io:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DharmitD DharmitD DharmitD left review comments

@gregsheremeta gregsheremeta Awaiting requested review from gregsheremeta

Assignees

@HumairAK HumairAK

@DharmitD DharmitD

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rimolive @HumairAK @DharmitD @openshift-merge-robot