Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARRY: Check if ODH CFO image exists and build image if needed #53

Closed
wants to merge 8 commits into from

Conversation

sutaakar
Copy link

@sutaakar sutaakar commented Apr 23, 2024

Build on top of project-codeflare#545.
Will be squashed to existing commit once approved.

Description

Build ODH CFO image if not found on Quay repository.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@sutaakar
Copy link
Author

@zdtsw FYI

@astefanutti
Copy link

/lgtm

@astefanutti
Copy link

/approve

Copy link

openshift-ci bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link
Member

zdtsw commented Apr 23, 2024

@zdtsw FYI

thanks @sutaakar
just to help me understand your PR: it is to do a pre-check before start the new image build process, right?
then mine will still be applied but on a different case which is running in any case once config/* is changed.

Copy link

openshift-ci bot commented Apr 23, 2024

@sutaakar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security e402c45 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sutaakar
Copy link
Author

@zdtsw The workflow is repurposed, with this change it is executed for every push into the main branch which modifies config/manager/params.env file.
First check verifies if image already exists on Quay. If exists then image build part is skipped. If not exist then image build is triggered, building new image.

As a result, every commit modifying image tag will trigger this workflow to rebuild the image.

@sutaakar
Copy link
Author

Change pushed directly to main branch to keep number of ODH commits limited. Closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants