Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: misc improvements #205

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Jan 24, 2024

  • avoid starting un-needed servers by adding RUNTIME_{GRPC,HTTP}_ENABLED env vars. This also fixes issues with the health probes reporting failures when container was started with python -m caikit.runtime.http_server or caikit.runtime.grpc_server
  • add missing TRANSFORMERS_CACHE env var to transformer-container
  • remove duplicated manifests

@@ -1,20 +0,0 @@
apiVersion: serving.kserve.io/v1beta1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,35 +0,0 @@
apiVersion: serving.kserve.io/v1alpha1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielezonca, dtrifiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1150f12 into opendatahub-io:main Jan 29, 2024
3 checks passed
@dtrifiro dtrifiro deleted the manifest-env-vars branch January 30, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants