Speed up integrity tests #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on PR #520.
The
TckScenarioFormatCheckwas set up to run tests in parallel, which however did not work. Unfortunately, it turned out that the parallel setup caused a massive amount of redundant execution. Looks like the check of every single scenario executed the ingestion of whole TCK, which makes scenario parsing quadratic in the number of scenarios — nothing promising with regards to execution speed. So that theTckScenarioFormatCheckend up needing over 20 minutes to check the TCK on a modern notebook computer.Removing the parallel setup (a very simple code change) turned out to result in significantly faster execution of the
TckScenarioFormatCheck. With this PR on the same computer, it checks the whole less than a minute.Given that
TckScenarioFormatCheckis part of every build run including testing, this is a very convenient and environmentally-friendly improvement.