Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on PR #520.
This PR add a little tool that does some syntax coverage analysis of the TCK scenarios.
The current output is:
In the grammar rules for expressions are “drop-through”, so that even a literal causes all expression non-terminals to show up in the parse tree. With regards to coverage that is obviously not very informative. Hence, the numbers above do not count rules with they
With that the expression numbers look much more informative.
The difference between the columns is as follows:
When executing query
step. For instance,RETURN 123, 456
, would haveNumberLiteral 2 1
. I do not know of any scenario having more than oneWhen executing query
step, so you can think of the second column as the number of scenarios where the tested query has at least one instance of the respective rules.I am still somewhat puzzled about where being practically no syntax which is not covered by a scenario query. However, potential reason are:
However, this is coverage of syntax — not of semantics.