-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object_Detection: YoloX (GSOC) #86
Conversation
Added Video input inference
- class name change - built-in function changes
This PR is for YoloX, so please remove the |
removed nanodet directory |
This comment was marked as resolved.
This comment was marked as resolved.
@Sidd1609 Could you squash commits into one? I am going to work on this pr and merge it this weekend if possible. |
Not sure what you mean by squash commits
Please could you elaborate?
…On Fri, Oct 21, 2022 at 12:39 PM Yuantao Feng ***@***.***> wrote:
@Sidd1609 <https://github.com/Sidd1609> Could you squash commits into
one? I am going to work on this pr and merge it this weekend if possible.
—
Reply to this email directly, view it on GitHub
<#86 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALTC7VYEKYWQKTUVLLPLADLWEI6RJANCNFSM57AGGXVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
You can see here in the picture you have 128 commits in total for this PR. When merging a PR, we don't need such a long commit history and we prefer only one commit. Learn more details here. You could squash commits with the following commands: $ git rebase -i HEAD~128 # number 128 is the number of your commits in this PR
# Then an editor will pop up. Leave the first commit as pick,
# and change the other commits from pick to squash. Exit the
# editor and a new page on the commit message will be opened.
# Compose a short and clear commit message and exit the editor.
# Squashing commits is done. There is a page talking details on squashing commits: https://www.git-tower.com/learn/git/faq/git-squash |
Oh got it yuantao
I think both the commits for nanodet and yolox have been taken into
consideration
I will work on it and send the updates
…On Fri, Oct 21, 2022 at 5:51 PM Yuantao Feng ***@***.***> wrote:
[image: image]
<https://user-images.githubusercontent.com/17219438/197192566-efaa8f4b-4c45-4325-9479-c49d1e3ffa61.png>
You can see here in the picture you have 128 commits in total for this PR.
When merging a PR, we don't need such a long commit history and we prefer
only one commit. Learn more details here
<https://docs.gitlab.com/ee/user/project/merge_requests/squash_and_merge.html>.
You could squash commits with the following commands:
$ git rebase -i HEAD~128 # number 128 is the number of your commits in this PR# Then an editor will pop up. Leave the first commit as pick,# and change the other commits from pick to squash. Exit the# editor and a new page on the commit message will be opened.# Compose a short and clear commit message and exit the editor.# Squashing commits is done.
There is a page talking details on squashing commits:
https://www.git-tower.com/learn/git/faq/git-squash
—
Reply to this email directly, view it on GitHub
<#86 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALTC7VY44KSEPTEVS66ACPTWEKDGJANCNFSM57AGGXVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
That's why these two PRs should be based on different branches. I will start working on your PRs when commits are squashed. |
Noted.
…On Fri, Oct 21, 2022 at 6:07 PM Yuantao Feng ***@***.***> wrote:
I think both the commits for nanodet and yolox have been taken into
consideration
That's why these two PRs should be based on different branches. I will
start working on your PRs when commits are squashed.
—
Reply to this email directly, view it on GitHub
<#86 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALTC7V6HZ4YH6HGI4YVWXSLWEKFA5ANCNFSM57AGGXVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
close in favor of #104 |
Updated files for object detection using YOLOX,
files uploaded for review:
COMPLETED:
TO DO: