-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text Detection: Add text detection metrics #73
Conversation
the-star-sea
commented
Jul 13, 2022
- add metrics(precision,recall,hmean,AP,avg time)
- fix a small print error in demo.py
We dont put evaluation script along with models. Please take a look at https://github.com/opencv/opencv_zoo/tree/master/tools/eval. |
I wanna add some specific functions for detection task. I think we need a discussion and I have talked about it with zihao Mu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
There are some code style issues. Please check the OpenCV code style of Python.
Is there a reference to rrc_evaluation_funcs.py
file? If you refer to the code, please attach the original license. If you refer to the paper, please attach a link to the header of the file.
@the-star-sea, please refactor the code according to the test framework for other models. And after that, I think we can merge it. |
Please, put the accuracy test in tools/eval. Benchmark is only for speed. |
I have just known this because my opencv_zoo is several months ago's type. |
This comment #73 (comment) is from July 14. |
I forgot it😭
Yuantao Feng ***@***.***> 于 2022年9月8日周四 23:57写道:
… We dont put evaluation script along with models. Please take a look at
https://github.com/opencv/opencv_zoo/tree/master/tools/eval.
This comment #73 (comment)
<#73 (comment)> is
from July 14.
—
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMMRV4OLS6476UK36PFIYX3V5LNUZANCNFSM53O2AJCQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I still have enough time to add it I think.How can I update and get the
evaluation in my branch?
Stone Zhang ***@***.***> 于 2022年9月9日周五 00:48写道:
… I forgot it😭
Yuantao Feng ***@***.***> 于 2022年9月8日周四 23:57写道:
> We dont put evaluation script along with models. Please take a look at
> https://github.com/opencv/opencv_zoo/tree/master/tools/eval.
>
> This comment #73 (comment)
> <#73 (comment)>
> is from July 14.
>
> —
> Reply to this email directly, view it on GitHub
> <#73 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AMMRV4OLS6476UK36PFIYX3V5LNUZANCNFSM53O2AJCQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
# fetch upstream changes
git remote add upstream https://github.com/opencv/opencv_zoo.git
git fetch upstream
# store your local changes
git reset HEAD~5 #(5 is the number of your commits)
git stash
# merge upstream changes
git merge upstream/master
# restore your changes
git stash apply
# check and resolve conflicts
git status |
@the-star-sea friendly reminder. |
I will complete this after my graduate application period .I have discussed
it with Zihao before.
Yuantao Feng ***@***.***>于2022年10月29日 周六20:46写道:
… @the-star-sea <https://github.com/the-star-sea> friendly reminder.
—
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMMRV4ML75XCHQOSIGABOKTWFXVSFANCNFSM53O2AJCQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@the-star-sea Do you plan to continue working on this pull request in the near future? |
I will do it in Jan or Feb 2023. I am sorry that I am busy for application
and final exams these days.
Yuantao Feng ***@***.***> 于2022年12月1日周四 19:32写道:
… @the-star-sea <https://github.com/the-star-sea> Do you plan to continue
working on this pull request in the near future?
—
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMMRV4NZLZA5QDVQLFRX7IDWLFUVDANCNFSM53O2AJCQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @the-star-sea, any update? |
Closing for no activities. |