Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Detection: Add text detection metrics #73

Closed
wants to merge 5 commits into from

Conversation

the-star-sea
Copy link
Contributor

  • add metrics(precision,recall,hmean,AP,avg time)
  • fix a small print error in demo.py

@fengyuentau fengyuentau added GSoC Google Summer of Code projected related evaluation adding tools for evaluation or bugs of eval scripts labels Jul 14, 2022
@fengyuentau fengyuentau self-requested a review July 14, 2022 02:44
@fengyuentau
Copy link
Member

We dont put evaluation script along with models. Please take a look at https://github.com/opencv/opencv_zoo/tree/master/tools/eval.

@the-star-sea
Copy link
Contributor Author

I wanna add some specific functions for detection task. I think we need a discussion and I have talked about it with zihao Mu.

Copy link
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
There are some code style issues. Please check the OpenCV code style of Python.

Is there a reference to rrc_evaluation_funcs.py file? If you refer to the code, please attach the original license. If you refer to the paper, please attach a link to the header of the file.

models/text_detection_db/cal_rescall/script.py Outdated Show resolved Hide resolved
models/text_detection_db/validation.py Outdated Show resolved Hide resolved
models/text_detection_db/validation.py Outdated Show resolved Hide resolved
models/text_detection_db/cal_rescall/script.py Outdated Show resolved Hide resolved
@zihaomu zihaomu changed the title Add text detection metrics OCR Detection: Add text detection metrics Jul 20, 2022
@zihaomu zihaomu changed the title OCR Detection: Add text detection metrics Text Detection: Add text detection metrics Jul 20, 2022
@zihaomu
Copy link
Member

zihaomu commented Aug 30, 2022

@the-star-sea, please refactor the code according to the test framework for other models. And after that, I think we can merge it.

@the-star-sea
Copy link
Contributor Author

Screenshot from 2022-09-08 21-23-06.png

@fengyuentau
Copy link
Member

Screenshot from 2022-09-08 21-23-06.png

Please, put the accuracy test in tools/eval. Benchmark is only for speed.

@the-star-sea
Copy link
Contributor Author

the-star-sea commented Sep 9, 2022

Screenshot from 2022-09-08 21-23-06.png

Please, put the accuracy test in tools/eval. Benchmark is only for speed.

I have just known this because my opencv_zoo is several months ago's type.
Screenshot from 2022-09-08 22-44-30.png

@fengyuentau
Copy link
Member

We dont put evaluation script along with models. Please take a look at https://github.com/opencv/opencv_zoo/tree/master/tools/eval.

This comment #73 (comment) is from July 14.

@the-star-sea
Copy link
Contributor Author

the-star-sea commented Sep 9, 2022 via email

@the-star-sea
Copy link
Contributor Author

the-star-sea commented Sep 9, 2022 via email

@fengyuentau
Copy link
Member

# fetch upstream changes
git remote add upstream https://github.com/opencv/opencv_zoo.git
git fetch upstream
# store your local changes
git reset HEAD~5 #(5 is the number of your commits)
git stash
# merge upstream changes
git merge upstream/master
# restore your changes
git stash apply
# check and resolve conflicts
git status

@fengyuentau
Copy link
Member

@the-star-sea friendly reminder.

@the-star-sea
Copy link
Contributor Author

the-star-sea commented Oct 30, 2022 via email

@fengyuentau
Copy link
Member

@the-star-sea Do you plan to continue working on this pull request in the near future?

@the-star-sea
Copy link
Contributor Author

the-star-sea commented Dec 2, 2022 via email

@zihaomu
Copy link
Member

zihaomu commented Feb 13, 2023

Hi @the-star-sea, any update?

@fengyuentau fengyuentau added the stale Issues or PRs marked as stale will be closed in 7 days label Feb 15, 2023
@fengyuentau fengyuentau marked this pull request as draft February 15, 2023 02:35
@fengyuentau
Copy link
Member

Closing for no activities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evaluation adding tools for evaluation or bugs of eval scripts GSoC Google Summer of Code projected related stale Issues or PRs marked as stale will be closed in 7 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants