Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DB demos #64

Merged
merged 4 commits into from
Jul 5, 2022
Merged

Add DB demos #64

merged 4 commits into from
Jul 5, 2022

Conversation

the-star-sea
Copy link
Contributor

  • add DB demo to frontpage

zihaomu
zihaomu reviewed Jun 27, 2022
View reviewed changes
Copy link
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. It would nice if you could provide Chinese and English gif Demo.

@the-star-sea the-star-sea requested a review from zihaomu June 27, 2022 16:18
fengyuentau
fengyuentau requested changes Jun 28, 2022
View reviewed changes
Copy link
Member

@fengyuentau fengyuentau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you replace the example of detecting Chinese characters with another one without QR code or anything privacy sensitive.

Besides, you should also add these two images to the readme in models/text_detection_db. It can even better if you present the command of how you run this demo and get the result image.

@the-star-sea the-star-sea requested a review from fengyuentau June 29, 2022 00:42
@the-star-sea
Copy link
Contributor Author

I suggest you replace the example of detecting Chinese characters with another one without QR code or anything privacy sensitive.

Besides, you should also add these two images to the readme in models/text_detection_db. It can even better if you present the command of how you run this demo and get the result image.

I see there is a shell in the readme of DBnet.

fengyuentau
fengyuentau approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me👍

@fengyuentau fengyuentau changed the title addDBfrontpage Add DB demos Jun 30, 2022
@fengyuentau fengyuentau added documentation Improvements or additions to documentation GSoC Google Summer of Code projected related labels Jun 30, 2022
zihaomu
zihaomu approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM 👍

@zihaomu zihaomu merged commit 2a0b523 into opencv:master Jul 5, 2022
fengyuentau pushed a commit that referenced this pull request Jun 8, 2023
@the-star-sea
Add DB demos (#64)
ba42259 
* addDBfrontpage

* add English DB

* change readme

* change two readme and replace images
@fengyuentau fengyuentau added this to the 4.9.0 (first release) milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengyuentau fengyuentau fengyuentau approved these changes

@zihaomu zihaomu zihaomu approved these changes

Assignees

@zihaomu zihaomu

Labels
documentation Improvements or additions to documentation GSoC Google Summer of Code projected related
Projects
None yet
Milestone
4.9.0 (first release)
Development

Successfully merging this pull request may close these issues.
3 participants
@the-star-sea @zihaomu @fengyuentau