Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 32FC1 type support and mask to cuda::meanStdDev implementation #3191

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Added 32FC1 type support and mask to cuda::meanStdDev implementation #3191

merged 1 commit into from
Mar 11, 2022

Conversation

asmorkalov
Copy link
Contributor

@asmorkalov asmorkalov commented Mar 5, 2022 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
buildworker:Custom=linux-4,linux-6
build_image:Custom=ubuntu-cuda:18.04

@asmorkalov asmorkalov requested a review from alalek March 5, 2022 08:27
@asmorkalov asmorkalov force-pushed the as/cuda_meanstddev branch 3 times, most recently from 935a997 to e380e38 Compare March 9, 2022 11:44
alalek
alalek reviewed Mar 9, 2022
View reviewed changes
modules/cudaarithm/include/opencv2/cudaarithm.hpp Outdated Show resolved Hide resolved
modules/cudaarithm/include/opencv2/cudaarithm.hpp Outdated Show resolved Hide resolved
modules/cudaarithm/include/opencv2/cudaarithm.hpp Outdated Show resolved Hide resolved
modules/cudaarithm/include/opencv2/cudaarithm.hpp Outdated Show resolved Hide resolved
@asmorkalov asmorkalov force-pushed the as/cuda_meanstddev branch 3 times, most recently from d99c3c9 to 75fff58 Compare March 10, 2022 08:11
alalek
alalek reviewed Mar 10, 2022
View reviewed changes
modules/cudaarithm/include/opencv2/cudaarithm.hpp Outdated
@param src Source matrix. CV_8UC1 and CV_32FC1 matrices are supported for now.
@param dst Target GpuMat with size 1x2 and type CV_64FC1. The first value is mean, the second - stddev.
@param mask Operation mask.
@param stream Cuda stream for asynchronous execution.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cuda stream

BTW, just Stream is used below. Or use CUDA (uppercase)

@opencv-pushbot opencv-pushbot merged commit dd8be23 into opencv:4.x Mar 11, 2022
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels
category: cuda feature test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asmorkalov @alalek @opencv-pushbot