Pass cv::VideoCaptureProperties to VideoReader FFmpeg source #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luding checks to ensure codec used in input video file is supported on the current device.
…o update_nvcuvid_codecs
# Conflicts: # modules/cudacodec/include/opencv2/cudacodec.hpp # modules/cudacodec/src/video_decoder.cpp
…zation. Include test for VideoReader but not for VideoCapture, assume pass through successful. Use propertyId instead of c++ keyword property. Remove unecessary error checks (parsers error is dependant on source) and output more informative exception.
cudawarped
changed the title
…sed and initialization fails and add test for this.
alalek
reviewed
Dec 24, 2021
Comment on lines
390
to
391
| @return Value for the specified property. Value 0 is returned when querying a property that is | ||
| not supported. |
There was a problem hiding this comment.
Value 0 is returned when querying a property that is not supported.
BTW, Zero is not a good "non-supported" value due to conflict with regular values of supported properties. It would be changed in the future somehow.
There was a problem hiding this comment.
I have changed both get methods to return the status to avoid magic numbers.
| @@ -176,6 +178,16 @@ void cv::cudacodec::detail::FFmpegVideoSource::updateFormat(const FormatInfo& vi | |||
| format_.valid = true; | |||
| } | |||
|
|
|||
| double cv::cudacodec::detail::FFmpegVideoSource::get(const int propId) const | |||
| { | |||
| if (videoCaptureParams.size() % 2 != 0) return 0; | |||
There was a problem hiding this comment.
Agreed, it should have failed earlier if true.
…ith VideoCapture::get Fix documentation.
alalek
reviewed
Dec 27, 2021
| */ | ||
| CV_WRAP virtual int get(const VideoReaderProps propertyId, const int propertyVal = -1) const = 0; | ||
| CV_WRAP virtual bool get(const VideoReaderProps propertyId, double& propertyValOut, const int propertyVal = -1) const = 0; |
There was a problem hiding this comment.
CV_WRAP
It needs to add CV_OUT specifier:
CV_OUT double& propertyValOut
const int propertyVal = -1
Perhaps we don't need this anymore.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow initialization properties
CAP_PROP_OPEN_TIMEOUT_MSEC,CAP_PROP_READ_TIMEOUT_MSECetc. to be passed to the FFmpeg backend which is used bycv::cudacodec::VideoReader.See #3138
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.