sfm: disable min
/max
macros under win32
#3083
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Visual Studio 2017, I observe in the
sfm
module errors such asopencv_contrib\modules\sfm\src\libmv_light\libmv/correspondence/matches.h(234): error C2589: '(': illegal token on right side of '::'
caused by
min
/max
being defined as macros. This PR adds theNOMINMAX
define to thesfm
module to avoid the macro definitions.Pull Request Readiness Checklist
Patch to opencv_extra has the same branch name.