ximgproc: add an assert in thinning() #2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalek
reviewed
Mar 17, 2021
modules/ximgproc/src/thinning.cpp
Outdated
| @@ -69,6 +69,7 @@ static void thinningIteration(Mat img, int iter, int thinningType){ | |||
| // Apply the thinning procedure to a given image | |||
| void thinning(InputArray input, OutputArray output, int thinningType){ | |||
| Mat processed = input.getMat().clone(); | |||
| CV_Assert(processed.type == CV_8UC1); | |||
There was a problem hiding this comment.
Consider using CV_CheckTypeEQ(input.type(), CV_8UC1, ""); for clear diagnostic messages.
berak
force-pushed
the
imgproc_fix_thinning
branch
from
c87b295 to
22cbfd6
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
resolves #2887