-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove normalization in cv::stereo::QuasiDenseStereo getDisparity(). #2869
Conversation
…parity maps with nan values for unknown matches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution!
// | ||
// | ||
// Intel License Agreement | ||
// For Open Source Computer Vision Library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use short license header: https://github.com/opencv/opencv/wiki/Coding_Style_Guide#file-structure
// This file is part of OpenCV project.
// It is subject to the license terms in the LICENSE file found in the top-level directory
// of this distribution and at http://opencv.org/license.html.
|
||
namespace opencv_test { namespace { | ||
|
||
class CV_QdsMatchingTest : public cvtest::BaseTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cvtest::BaseTest
BTW, It makes sence to avoid using of legacy OpenCV testing infrastructure.
Prefer to use GoogleTest directly.
Start from this and then replace legacy calls (like printf => EXPECT_*()
/ ASSERT_*()
):
-class
...
-void CV_QdsMatchingTest::run(int)
+TEST(qds_matching_simple_test, accuracy)
...
-TEST(qds_matching_simple_test, accuracy) { CV_QdsMatchingTest test; test.safe_run(); }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for that, I used the test files from the other stereo modules as templates, when I was writing qds' test, assuming that those follow the guidelines. I will make changes later this week, thanks for your help.
This addresses user comments made in #1941 and #2819. The getDisparity function, of QuasiDenseStereo, originally returned a disparity image normalized to span the full range between 0 and 255, which was improper and understandably confused users.
I've made the following changes:
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.