Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deltaCIEDE2000_ fix into the MCC module #2845

Merged
merged 2 commits into from
Feb 5, 2021

Conversation

kevineor
Copy link
Contributor

@kevineor kevineor commented Jan 29, 2021

DeltaE CIEDE2000 function fix into MCC module

This function did not pass the test case 17 and 19 of Gaurav Sharma's test data.

This was due to a mistake into the "RT" value, it was computed with the value image instead of image.

Sources :

And now i have a little question about this module, why color conversion and color distances classes are not exposed to the API ?
They are really useful because, at the moment, OpenCV can't convert sRGB D65 2° to CIELAB D50 2° or perform any CIE color comparison.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Member

alalek commented Jan 29, 2021

/cc @riskiest Could you please take a look?

@kevineor
Copy link
Contributor Author

kevineor commented Feb 3, 2021

Where does the test data come from? Should i change it?

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alalek alalek merged commit 461b56f into opencv:master Feb 5, 2021
@alalek alalek mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug category: mcc color calibration module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants