Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aruco] do not copy image if already a grey-image #2785

Merged
merged 1 commit into from
Dec 10, 2020
Merged

[aruco] do not copy image if already a grey-image #2785

merged 1 commit into from
Dec 10, 2020

Conversation

esopalumpa
Copy link
Contributor

@esopalumpa esopalumpa commented Dec 10, 2020 •
edited
Loading

Images are InputArrays and need not beeing copied here.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@esopalumpa
[aruco] do not copy image if already a grey-image
4d9e025 
Images are InputArrays and need not beeing copied here.
@esopalumpa esopalumpa mentioned this pull request Dec 10, 2020
Closed
alalek
alalek approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for contribution 👍

@opencv-pushbot opencv-pushbot merged commit 332ae5b into opencv:3.4 Dec 10, 2020
@alalek alalek mentioned this pull request Dec 11, 2020
Merged
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels
category: aruco
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esopalumpa @alalek @opencv-pushbot