-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freetype2: Fix comments in freetype.hpp and README.md #2776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution.
Please take a look on comments below.
@param text Text string to be drawn. | ||
@param org Bottom-left/Top-left corner of the text string in the image. | ||
@param fontHeight Drawing font size by pixel unit. | ||
@param color Text color. | ||
@param color Text color.(Only 3ch 8bit Scalar is supported.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8bit
Scalar values are double
s by design.
I believe we should mention used range, like 0-255, here instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
Because freetype2 wrapper module requests that img is 8UC3, I reconsider this limitation of color is very clear.
- first 3 channels of 'color' are used, 4th channel of it is not.
- The range of element are 0-255.
This change is not necessary. I cancel adding comment.
modules/freetype/README.md
Outdated
Installation | ||
----------- | ||
Requested external libraries. | ||
------------------------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove dots from the Headers
Please align number of ===
/ ---
symbols on the next line (as markdown requested)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much ! I'll fix it.
- Remove dots from the Headers - Align number of === / --- symbols on the next line
Fix #2771 and related small problems about documentation.
Installation
is replaced asRequested external libraries
Usage
is update to it can be compile in real.Future work
is removed.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.