Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test ED_Lib #2313

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Test ED_Lib #2313

merged 2 commits into from
Apr 2, 2021

Conversation

sturkmen72
Copy link
Contributor

This pullrequest changes

initial test PR to add EDGE DRAWING LIBRARY ( original code is in https://github.com/CihanTopal/ED_Lib)

@sturkmen72 sturkmen72 mentioned this pull request Oct 26, 2019
Open
alalek
alalek reviewed Oct 26, 2019
View reviewed changes
modules/ximgproc/src/ED.h Outdated
* E-mails of the authors: [email protected], [email protected]
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we can't accept code under GPL license.

BTW, License file from upstream repository contains MIT license: https://github.com/CihanTopal/ED_Lib/blob/7f171db0321de67b12ee3d0558b0b1d60122000d/LICENSE

@sturkmen72 sturkmen72 changed the base branch from master to 3.4 October 29, 2019 13:53
@sturkmen72 sturkmen72 force-pushed the test_Edge_Drawing_Algos branch 13 times, most recently from 7c41cb5 to 322a338 Compare November 3, 2019 11:42
@sturkmen72 sturkmen72 force-pushed the test_Edge_Drawing_Algos branch from 322a338 to 35ffa76 Compare November 12, 2019 22:52
@sturkmen72
Copy link
Contributor Author

a nice surprise to me, it was already in the library and works without problematic NFA code

still working on the PR

@sturkmen72 sturkmen72 force-pushed the test_Edge_Drawing_Algos branch from 230dd22 to bc96ff6 Compare November 17, 2019 08:00
@alalek
Copy link
Member

alalek commented Nov 19, 2019

Variables starting with underscore ("_") and capital letter are reserved: https://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier

@sturkmen72 sturkmen72 force-pushed the test_Edge_Drawing_Algos branch 2 times, most recently from 5535cf3 to ac5dc05 Compare November 25, 2019 19:58
@sturkmen72 sturkmen72 force-pushed the test_Edge_Drawing_Algos branch 2 times, most recently from d6b626b to bb65b64 Compare December 3, 2019 19:26
@sturkmen72 sturkmen72 force-pushed the test_Edge_Drawing_Algos branch from d5cec31 to a71820e Compare December 15, 2019 00:02
@sturkmen72
Copy link
Contributor Author

hi @alalek,
progress of the PR is slow due to my personal business. but i believe that the code can be merged for test purpose. what is your opinion?

@bbenligiray bbenligiray mentioned this pull request Mar 26, 2020
Open
@sturkmen72 sturkmen72 closed this Jul 5, 2020
@sturkmen72 sturkmen72 reopened this Jul 5, 2020
@sturkmen72 sturkmen72 force-pushed the test_Edge_Drawing_Algos branch from d2ae2d9 to 7310f90 Compare October 2, 2020 18:18
@sturkmen72 sturkmen72 force-pushed the test_Edge_Drawing_Algos branch 21 times, most recently from 94ceb1c to b56c79c Compare April 1, 2021 15:52
@sturkmen72
Copy link
Contributor Author

@alalek i will rebase commits after you review additional commit.

@sturkmen72 sturkmen72 force-pushed the test_Edge_Drawing_Algos branch from f041211 to 79d9b95 Compare April 1, 2021 19:58
@alalek
eliminate build warning
06ed51e 
- warning: array subscript is below array bounds [-Warray-bounds]
@alalek alalek merged commit f7efcba into opencv:3.4 Apr 2, 2021
@alalek alalek mentioned this pull request Apr 2, 2021
Merged
@sturkmen72 sturkmen72 deleted the test_Edge_Drawing_Algos branch April 2, 2021 04:44
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels
category: python bindings category: samples category: ximgproc feature test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sturkmen72 @alalek