Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get/set for FastThreshold #2199

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

wugulabs
Copy link

@wugulabs wugulabs commented Jul 24, 2019

#1597

This pullrequest changes

Extend the interface of the ORB class by adding a getter and setter for the FastThreshold parameter

force_builders=Custom
buildworker:Custom=linux-1,linux-2,linux-4
docker_image:Custom=ubuntu-cuda:16.04

@wugulabs
Copy link
Author

Although I just expose two additional functions, 1 test fails in Linux x64 (all other plaforrms build fine), namely:

  • Face/MACE_.salted/1, where GetParam() = ("dudek")

This failure is unrelated to the (small) changes made by this PR.
How to continue from here?

@berak
Copy link
Contributor

berak commented Jul 24, 2019

hello @wugulabs ,

This failure is unrelated to the (small) changes made by this PR.

indeed, not your fault. sporadic test failure, i'll look into making it more robust.

How to continue from here?

maybe just wait. the next rebuild will probably fix it.

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

@opencv-pushbot opencv-pushbot merged commit a197133 into opencv:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants