added detection of inverted Markers, tests included #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalek
reviewed
Mar 25, 2019
| // to get from 255 to 1 | ||
| int invBError = _getBorderErrors(~candidateBits-254, dictionary->markerSize, params->markerBorderBits); | ||
| // white marker | ||
| if(invBError<borderErrors){ |
There was a problem hiding this comment.
Please fix indentation (it is "jumping").
| for(int yaw = 30; yaw <= 90; yaw += 50) { | ||
| for(double distance = 0.1; distance < 0.7; distance += 0.2) { | ||
| for(int pitch = 0; pitch < 360; pitch += (distance == 0.1? 60:180)) { | ||
| for(int yaw = 70; yaw <= 120; yaw += 40){ |
There was a problem hiding this comment.
int yaw = 70; yaw <= 120; yaw += 40
yaw: 70, 110 ?
Old yaw values are: 30, 80
There was a problem hiding this comment.
even though the detection of a default marker happens using that yaw value, it was not the case for the inverted marker, however, it also occurs in the opposite way, that is, where the inverted marker is detected more easily than the default marker.
Merged
Saafke
pushed a commit
to Saafke/opencv_contrib
that referenced
this pull request
Jun 24, 2019
* added detection of inverted Markers, tests included * corrections added, default preserved, identation, var, comment
|
The dictionary has to be inverted too? |
|
Hi @hamddan4, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullrequest introduces the detection of inverted markers
i.e. it allows to detect white markers on a black background
Inverted Marker
Enclosed-Inverted Marker
