Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Quality Analysis (IQA) API #1990

Merged
merged 26 commits into from
Feb 16, 2019
Merged

Image Quality Analysis (IQA) API #1990

merged 26 commits into from
Feb 16, 2019

Conversation

clunietp
Copy link
Contributor

@clunietp clunietp commented Feb 9, 2019

This pullrequest changes

Implements an image quality analysis API

Needed a new PR due to git wrangling. Continuation of #1959

@alalek
Copy link
Member

alalek commented Feb 11, 2019

No need to reopen PR or create new branch - just use "--force" option with "git push" command.

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better!

modules/quality/include/opencv2/quality/quality_utils.hpp Outdated Show resolved Hide resolved
modules/quality/test/test_precomp.hpp Show resolved Hide resolved
modules/quality/src/precomp.hpp Show resolved Hide resolved
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you 👍

@alalek alalek merged commit 796853e into opencv:master Feb 16, 2019
@clunietp
Copy link
Contributor Author

Thank you @alalek !

@clunietp clunietp deleted the quality-2 branch February 16, 2019 17:13
@PhilLab
Copy link
Contributor

PhilLab commented Feb 18, 2019

Thank you for the new module and contribution 👍

@alalek While the README.md is much more convenient in Github, the official documentation completely ignores it. And not only, for this module, also (for example) the cnn3dobj Readme is omitted. I am not familiar with the OpenCV doc build toolchain, but in our projects, we have a script which adds @addtogroup XYZ to the beginning of each README.md and thus it appears in the module overview page

@clunietp
Copy link
Contributor Author

@PhilLab Yes I need to improve the OpenCV docs for this module, thank you for the reminder! The @addtogroup trick at the top of a README.md would be great (if it works here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants