Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunks/enum interface #1744

Merged
merged 8 commits into from
Sep 21, 2018
Merged

Chunks/enum interface #1744

merged 8 commits into from
Sep 21, 2018

Conversation

cv3d
Copy link
Contributor

@cv3d cv3d commented Aug 31, 2018 •
edited by alalek
Loading

Please merge with opencv/opencv#12310

This pullrequest changes

Refer to opencv/opencv#12288 for details

force_builders=Custom,linux32,win32,oclmacosx,windows_vc15
docker_image:Custom=ubuntu-cuda:16.04
allow_multiple_commits=1

@cv3d cv3d mentioned this pull request Aug 31, 2018
Merged
@cv3d cv3d force-pushed the chunks/enum_interface branch 7 times, most recently from 690aaea to 1bcdc18 Compare September 7, 2018 11:39
alalek
alalek approved these changes Sep 7, 2018
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@cv3d cv3d force-pushed the chunks/enum_interface branch from 1bcdc18 to 8c04456 Compare September 19, 2018 21:53
@cv3d
Copy link
Contributor Author

cv3d commented Sep 19, 2018 •
edited
Loading

@alalek I am sorry to ask for revision again as CUDA enums got moved here..

@alalek
Copy link
Member

alalek commented Sep 19, 2018

Please take a look on failed builds.

@cv3d cv3d force-pushed the chunks/enum_interface branch from 8c04456 to 23ad88b Compare September 19, 2018 22:05
@cv3d cv3d force-pushed the chunks/enum_interface branch from 23ad88b to 72e55f5 Compare September 19, 2018 22:07
@cv3d
Copy link
Contributor Author

cv3d commented Sep 19, 2018

@alalek All green now!

@opencv-pushbot opencv-pushbot merged commit 72e55f5 into opencv:master Sep 21, 2018
opencv-pushbot pushed a commit that referenced this pull request Sep 21, 2018
@alalek
Merge pull request #1744 from cv3d:chunks/enum_interface
f9eaef9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cv3d @alalek @opencv-pushbot