run length morphology #1672
Merged
run length morphology #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalek
reviewed
Jun 29, 2018
| // | ||
| // | ||
| // License Agreement | ||
| // For Open Source Computer Vision Library |
There was a problem hiding this comment.
OpenCV samples should not have license header.
| * | ||
| * License Agreement | ||
| * For Open Source Computer Vision Library | ||
| * (3 - clause BSD License) |
There was a problem hiding this comment.
Please use short 3-line OpenCV license header (similar to perf_run_length_morphology.cpp file):
// This file is part of OpenCV project.
// It is subject to the license terms in the LICENSE file found in the top-level directory
// of this distribution and at http://opencv.org/license.html.
|
|
||
| #ifndef __OPENCV_RUN_LENGTH_MORPHOLOGY_HPP__ | ||
| #define __OPENCV_RUN_LENGTH_MORPHOLOGY_HPP__ | ||
| #ifdef __cplusplus |
There was a problem hiding this comment.
Please remove #ifdef __cplusplus - it is not necessary.
|
|
||
| typedef tuple<int, Size, int> RLParams; | ||
|
|
||
| typedef TestBaseWithParam<RLParams> RLMorphologyPerfTest; |
There was a problem hiding this comment.
BTW, indentation in namespaces are not required.
| PERF_TEST_P(RLMorphologyPerfTest, perf, Combine(Values(1,7, 21), Values(sz720p, sz2160p), | ||
| Values(MORPH_ERODE, MORPH_DILATE, MORPH_OPEN, MORPH_CLOSE, MORPH_GRADIENT,MORPH_TOPHAT, MORPH_BLACKHAT))) | ||
| { | ||
| RNG rng(0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
The pull request adds support for binary morphology on run-length encoded images. Run-length encoding is a well known data structure for fast binary image operations. A more recent reference is "Binary Morphology and Related Operations on Run-Length Representations." (Breuel, 2008).
The patch adds functions which operate similar to the morphology operations in imgproc. Conversion to binary run-length encoded images can be done by a thresholding operation.
With the supplied example application speedups of over 10x in comparison to the implementation in imgproc were measured on a Intel i7-5820 system with Nvidia Geforce 970 graphics card. The measurements were taken with circular structuring elements of large size (e.g. 70). On the other hand imgproc routines are often a lot faster with smaller structuring elements than the supplied functions. Running times also depend on the image content.
The code was developed from scratch (some years ago). A short introduction of the functionality can be found in the doxygen documentation in ximgproc/include/opencv2/ximgproc.hpp.