enter_modify #342

LYPWYT · 2023-11-10T12:20:23Z

fix #324
Make the curveadm enter command enter the leader container without parameters

Signed-off-by: Cyber-SiKu <[email protected]>

With database disk records commited by `disks.yaml`, disk formatting cloud be performed without `format.yaml`. And it will get and wirte disk `size` and `URI` during disk formatting, thus record the ID of service(chunkserver) with associated disk when deploy curvebs cluster. Use `curveadm disks ls` to view all disk information. Usage: curveadm disks commit /path/to/disks.yaml curveadm disks ls curveadm format Signed-off-by: Lijin Xiong <[email protected]>

Feature: support managing disk information in database

Disk UUID will be wrote into the config of service(chunkserver) container during curvebs deployment if disks `service_mount_device` was set `true`, then the service could directly mount disk device via `entrypoint.sh` and restart automatically after host power recover. Signed-off-by: Lijin Xiong <[email protected]>

Feature: support direct disk mounting for service container

Signed-off-by: Cyber-SiKu <[email protected]>

Signed-off-by: Cyber-SiKu <[email protected]> Set the restart policy of the client container to unless-stopped, so that it will automatically remount when the machine restarts Signed-off-by: Cyber-SiKu <[email protected]>

Signed-off-by: fengshunli <[email protected]>

Fix: format code

Co-authored-by: jolly-sy <[email protected]> Co-authored-by: Hanqing Wu <[email protected]> Signed-off-by: jolly-sy <[email protected]>

Signed-off-by: Cyber-SiKu <[email protected]>

Signed-off-by: wanghai01 <[email protected]>

Support manage curve monitor, curve website and support http service

Signed-off-by: montaguelhz <[email protected]>

Signed-off-by: wanghai01 <[email protected]>

fix clean monitor

Signed-off-by: wanghai01 <[email protected]>

fix generate target.json when curvefs

Signed-off-by: wanghai01 <[email protected]>

add dirs http service need

Signed-off-by: wanghai01 <[email protected]>

Signed-off-by: sjf <[email protected]>

Signed-off-by: jyf111 <[email protected]>

[fix]playbook: fix format related variables position

Signed-off-by: Wine93 <[email protected]>

…tion solution: execute the ss command in a temporary container to precheck for ports in use instead Signed-off-by: jyf111 <[email protected]>

Signed-off-by: xiaoming <[email protected]> [fix]playbook: fix format related variables position Signed-off-by: sjf <[email protected]> [fix] add support for recognizing kernel versions like "3.15.0_.*" Signed-off-by: jyf111 <[email protected]> support enable etcd auth Signed-off-by: wanghai01 <[email protected]> Feature: podman can be an alternative container engine Signed-off-by: caoxianfei1 <[email protected]> bugfix: docker ps specify both --format and --quiet will warning since v24.0.0. WARNING: Ignoring custom format, because both --format and --quiet are set. Signed-off-by: caoxianfei1 <[email protected]> change replicas to instances Signed-off-by: tec-rubbish maker <[email protected]> change topology variable change service_replicas_sequence and format_replicas_sequence to service_instances_sequence and format_instances_sequence Signed-off-by: tec-rubbish maker <[email protected]> fix the worng instances Signed-off-by: tec-rubbish maker <[email protected]> mistake Signed-off-by: tec-rubbish maker <[email protected]> Update cli/command/status.go Signed-off-by: Wine93 <[email protected]> [fix] older versions of the ss command do not have the --no-header option solution: execute the ss command in a temporary container to precheck for ports in use instead Signed-off-by: jyf111 <[email protected]> Signed-off-by: xiaoming <[email protected]>

Signed-off-by: sjf <[email protected]>

caoxianfei1 · 2023-11-15T07:41:38Z

@LYPWYT BTW, squash into one commit first.

caoxianfei1 · 2023-11-20T05:47:30Z

cli/command/enter.go

+	} else {
+		// If no id parameter, execute the following
+		// 2) generate get status playbook
+		statusForLeaderOptions := statusOptions{id: "*", role: "*", host: "*"}


May be only need role: "mds"

caoxianfei1 · 2023-11-20T05:48:09Z

cli/command/enter.go

+		if err != nil {
+			return err
+		}
+		// 4) display service status


The comment is improper

caoxianfei1 · 2023-11-20T05:49:21Z

cli/command/enter.go

+		}
+		// 4) display service status
+		statuses := []task.ServiceStatus{}
+		value := curveadm.MemStorage().Get(comm.KEY_ALL_SERVICE_STATUS)


May be we can set other KEY that no need to be same with status command.

caoxianfei1 · 2023-11-20T05:51:37Z

internal/playbook/factory.go

+		case GET_SERVICE_STATUS_FOR_LEADER:
+			t, err = comm.NewGetServiceStatusForLeaderTask(curveadm, config.GetDC(i))


GET_MDS_LEADER is better?

caoxianfei1 · 2023-11-20T05:53:53Z

internal/task/task/common/service_status.go

+	t.AddStep(&Step2GetListenPorts{
+		ContainerId: containerId,
+		Status:      &status,
+		Ports:       &ports,
+		ExecOptions: curveadm.ExecOptions(),
+	})


The step is not necessary and define other function and struct instead of using ServiceStatus.

caoxianfei1 · 2023-11-20T05:54:44Z

internal/task/task/common/service_status.go

+	t.AddStep(&step2FormatServiceStatus{
+		dc:          dc,
+		serviceId:   serviceId,
+		containerId: containerId,
+		isLeader:    &isLeader,
+		ports:       &ports,
+		status:      &status,
+		memStorage:  curveadm.MemStorage(),
+	})


Completed modifications as required

Signed-off-by: lyp <[email protected]> enter_modify_1 Signed-off-by: lyp <[email protected]> error handling enter Signed-off-by: lyp <[email protected]> error handling enter Signed-off-by: lyp <[email protected]> enter handling enter Signed-off-by: lyp <[email protected]> enter modify 2 Signed-off-by: lyp <[email protected]>

caoxianfei1 · 2023-11-24T07:37:23Z

please push it to develop branch again.

caoxianfei1 · 2023-12-01T09:42:56Z

@LYPWYT rebase mistake?

Cyber-SiKu and others added 30 commits February 22, 2023 14:14

[fix]playbook/memcached

c0a38f1

Signed-off-by: Cyber-SiKu <[email protected]>

[fix]playbook/memcached

10994d9

Signed-off-by: Cyber-SiKu <[email protected]>

Merge pull request #188 from legionxiong/new-disk-format

af342de

Feature: support managing disk information in database

Merge pull request #201 from legionxiong/auto-mount-disk

397fc08

Feature: support direct disk mounting for service container

[feat] add toolsv2

78c415a

Signed-off-by: Cyber-SiKu <[email protected]>

[feat]curvefs/curvebs: auto restart&mount

d7db7c6

Signed-off-by: Cyber-SiKu <[email protected]> Set the restart policy of the client container to unless-stopped, so that it will automatically remount when the machine restarts Signed-off-by: Cyber-SiKu <[email protected]>

Fix: remove deprecated ioutil

050eb05

Signed-off-by: fengshunli <[email protected]>

Fix: update package dependencies

5feab2c

Signed-off-by: fengshunli <[email protected]>

Feat: add golangci-lint

5c622b9

Signed-off-by: fengshunli <[email protected]>

Fix: format code

62d83a2

Signed-off-by: fengshunli <[email protected]>

Merge pull request #236 from fengshunli/code

f90ed57

Fix: format code

feature(curvebs): support poolset

9e46bbe

Co-authored-by: jolly-sy <[email protected]> Co-authored-by: Hanqing Wu <[email protected]> Signed-off-by: jolly-sy <[email protected]>

[fix] repace harbor with opencurve

8fa1398

Signed-off-by: Cyber-SiKu <[email protected]>

support deploy monitor

26a6b3c

Signed-off-by: wanghai01 <[email protected]>

add http service

c896257

Signed-off-by: wanghai01 <[email protected]>

support deploy website

1ab4aac

Signed-off-by: wanghai01 <[email protected]>

Merge pull request #250 from SeanHai/curve-manager

7cee1b6

Support manage curve monitor, curve website and support http service

[fix] update the example

15076a4

Signed-off-by: montaguelhz <[email protected]>

fix clean monitor

e150a3b

Signed-off-by: wanghai01 <[email protected]>

Merge pull request #262 from SeanHai/auth

d750c94

fix clean monitor

fix generate target.json when curvefs

8c55ada

Signed-off-by: wanghai01 <[email protected]>

Merge pull request #264 from SeanHai/auth

60cee71

fix generate target.json when curvefs

add dirs http service need

7d3bd4b

Signed-off-by: wanghai01 <[email protected]>

Merge pull request #276 from SeanHai/auth

3b6b0a1

add dirs http service need

support enable etcd auth

dc048d1

Signed-off-by: wanghai01 <[email protected]>

[fix]playbook: fix format related variables position

eeda84f

Signed-off-by: sjf <[email protected]>

[fix] add support for recognizing kernel versions like "3.15.0_.*"

df9eea9

Signed-off-by: jyf111 <[email protected]>

Merge pull request #305 from Songjf-ttk/fixposition

b1c5562

[fix]playbook: fix format related variables position

Wine93 and others added 4 commits September 12, 2023 09:45

Update cli/command/status.go

28dd6b0

Signed-off-by: Wine93 <[email protected]>

[fix] older versions of the ss command do not have the --no-header op…

a13b532

…tion solution: execute the ss command in a temporary container to precheck for ports in use instead Signed-off-by: jyf111 <[email protected]>

[feat]curveadm: add clean command for bs format

14c8166

Signed-off-by: sjf <[email protected]>

LYPWYT marked this pull request as ready for review November 11, 2023 07:14

caoxianfei1 reviewed Nov 20, 2023

View reviewed changes

cli/command/enter.go Outdated

if err != nil {

return err

}

// 4) display service status

Copy link

Contributor

caoxianfei1 Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is improper

caoxianfei1 reviewed Nov 20, 2023

View reviewed changes

caoxianfei1 added the developer activities label Nov 27, 2023

LYPWYT closed this Nov 29, 2023

LYPWYT reopened this Nov 29, 2023

LYPWYT closed this Nov 29, 2023

LYPWYT reopened this Nov 29, 2023

LYPWYT closed this Nov 29, 2023

LYPWYT reopened this Nov 29, 2023

LYPWYT closed this Nov 29, 2023

LYPWYT reopened this Nov 29, 2023

LYPWYT changed the base branch from tombstone to develop November 29, 2023 13:23

LYPWYT changed the base branch from develop to tombstone November 30, 2023 01:35

LYPWYT changed the base branch from tombstone to develop November 30, 2023 02:20

LYPWYT changed the base branch from develop to tombstone November 30, 2023 09:54

LYPWYT changed the base branch from tombstone to develop November 30, 2023 10:36

LYPWYT closed this by deleting the head repository Dec 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enter_modify #342

enter_modify #342

LYPWYT commented Nov 10, 2023 •

edited

Loading

caoxianfei1 commented Nov 15, 2023

caoxianfei1 Nov 20, 2023

caoxianfei1 Nov 20, 2023

caoxianfei1 Nov 20, 2023

caoxianfei1 Nov 20, 2023

caoxianfei1 Nov 20, 2023

caoxianfei1 Nov 20, 2023

LYPWYT Nov 22, 2023

caoxianfei1 commented Nov 24, 2023 •

edited

Loading

caoxianfei1 commented Dec 1, 2023

		case GET_SERVICE_STATUS_FOR_LEADER:
		t, err = comm.NewGetServiceStatusForLeaderTask(curveadm, config.GetDC(i))

enter_modify #342

enter_modify #342

Conversation

LYPWYT commented Nov 10, 2023 • edited Loading

caoxianfei1 commented Nov 15, 2023

caoxianfei1 Nov 20, 2023

Choose a reason for hiding this comment

caoxianfei1 Nov 20, 2023

Choose a reason for hiding this comment

caoxianfei1 Nov 20, 2023

Choose a reason for hiding this comment

caoxianfei1 Nov 20, 2023

Choose a reason for hiding this comment

caoxianfei1 Nov 20, 2023

Choose a reason for hiding this comment

caoxianfei1 Nov 20, 2023

Choose a reason for hiding this comment

LYPWYT Nov 22, 2023

Choose a reason for hiding this comment

caoxianfei1 commented Nov 24, 2023 • edited Loading

caoxianfei1 commented Dec 1, 2023

LYPWYT commented Nov 10, 2023 •

edited

Loading

caoxianfei1 commented Nov 24, 2023 •

edited

Loading