[feat]Curveadm: add debug mode #303

Songjf-ttk · 2023-08-28T09:25:15Z

Related to #252.

Solution: Add a debug option to the configuration file curvedm.cfg.

Test:

The container was not automatically deleted when an error occurred

Wine93 · 2023-08-28T11:34:26Z

Hi @Songjf-ttk, do you think is it more convenient to add a debug flag for format and deploy command?

e.g.

curveadm format --debug 
curveadm deploy --debug

Songjf-ttk · 2023-08-29T01:33:51Z

Yes, I think so. I will modify my code as soon as possible. @Wine93

Wine93 · 2023-09-01T01:54:47Z

cli/command/deploy.go

@@ -111,6 +111,7 @@ type deployOptions struct {
 	insecure        bool
 	poolset         string
 	poolsetDiskType string
+	debugDeploy     bool


Maybe debug is more clearly.

Wine93 · 2023-09-01T01:55:41Z

cli/command/format.go

+	filename    string
+	showStatus  bool
+	stopFormat  bool
+	debugFormat bool


Wine93 · 2023-09-01T01:57:10Z

cli/command/deploy.go

@@ -238,6 +241,7 @@ func genDeployPlaybook(curveadm *cli.CurveAdm,
 		} else if step == CREATE_LOGICAL_POOL {
 			options[comm.KEY_CREATE_POOL_TYPE] = comm.POOL_TYPE_LOGICAL
 		}
+		options[comm.DEBUG_MODE] = debugDeploy


Sugesstion:

options := map[string]interface{}{ comm.DEBUG_MODE: debug, } if step == CREATE_PHYSICAL_POOL { // do something } ...

Wine93 · 2023-09-01T02:08:34Z

cli/command/format.go

+	showStatus := options.showStatus
+	stopFormat := options.stopFormat
+	debugFormat := options.debugFormat
+	if showStatus && stopFormat {


Maybe you can do this in PreRunE phase, see:

curveadm/cli/command/deploy.go

Line 139 in 956c953

PreRunE: func(cmd *cobra.Command, args []string) error {

caoxianfei1 · 2023-09-15T09:28:32Z

internal/task/task/bs/format.go

+	debugmode := curveadm.MemStorage().Get(comm.DEBUG_MODE).(bool)
+	if debugmode {
+		glg.Get().SetLevel(glg.DEBG)
+	}


no need to adjust the log level here. the log level should be determined by the configuration file.

There are two ways to implement debug mode. The first is to directly modify curveadm.cfg and read the log level through the configuration file. The second method is to configure the debug mode through the command line, such as :

curveadm format --debug curveadm deploy --debug

After communicating with @Wine93 this time, I chose this solution. This Solution set the debug mode in the command line, which may conflict with the log level in curveadm.cfg, so it is necessary to modify the log level.

There are two ways to implement debug mode. The first is to directly modify curveadm.cfg and read the log level through the configuration file. The second method is to configure the debug mode through the command line, such as :

curveadm format --debug curveadm deploy --debug

After communicating with @Wine93 this time, I chose this solution. This Solution set the debug mode in the command line, which may conflict with the log level in curveadm.cfg, so it is necessary to modify the log level.

yep, maybe you can provide a function for curveadm to set log level.

caoxianfei1 · 2023-09-15T09:28:59Z

internal/task/task/checker/network.go

+	if debugmode {
+		glg.Get().SetLevel(glg.DEBG)
+		return nil, nil
+	}


caoxianfei1 · 2023-09-15T09:32:07Z

internal/task/task/common/create_container.go

@@ -279,6 +280,7 @@ func NewCreateContainerTask(curveadm *cli.CurveAdm, dc *topology.DeployConfig) (
 		Init:        true,
 		Name:        hostname,
 		Privileged:  true,
+		Remove:      !debugmode,


here is a problem, the service container exit but don't delete it forever util delete it manually.

caoxianfei1 · 2023-09-18T03:29:32Z

cli/command/format.go

@@ -133,6 +170,11 @@ func runFormat(curveadm *cli.CurveAdm, options formatOptions) error {
 	var err error
 	var fcs []*configure.FormatConfig
 	diskRecords := curveadm.DiskRecords()
+	debugmode   := options.debug


duplicate with line 128?
debug := options.debug
debugmode := options.debug

caoxianfei1 · 2023-09-20T10:56:23Z

@Songjf-ttk look at the other comments.

caoxianfei1 · 2023-09-22T09:07:50Z

@Songjf-ttk

The format complete but status is formatting when test it. You may need to lookup format_status.go file and modify the logic.
By the way, should we provide a command such curveadm format --clean? In this way we can delete these format containers that exist but exited because we use curveadm format --debug for avoid skipping when reformatting.

Songjf-ttk · 2023-10-05T14:21:43Z

@Songjf-ttk The format complete but status is formatting when test it. You may need to lookup format_status.go file and modify the logic. By the way, should we provide a command such curveadm format --clean? In this way we can delete these format containers that exist but exited because we use curveadm format --debug for avoid skipping when reformatting.

The reason status is 'formatting' is because curveadm determines the status based on the container's Status. It has now been fixed:

else if len(*s.containerStatus) > 1 && !strings.Contains(*s.containerStatus, "Exited")

add a command clean to delete the container

curveadm format --clean

caoxianfei1 · 2023-10-07T08:06:13Z

@Songjf-ttk please squash to one commit.

caoxianfei1 · 2023-10-07T08:07:52Z

cli/command/format.go

+	showStatus  bool
+	stopFormat  bool
+	debug       bool
+	cleanFormat bool


clean instead of cleanFormat is better?

clean instead of cleanFormat is better?

Agree!

caoxianfei1 · 2023-10-07T08:08:27Z

cli/command/format.go

@@ -82,6 +122,8 @@ func NewFormatCommand(curveadm *cli.CurveAdm) *cobra.Command {
 	flags.StringVarP(&options.filename, "formatting", "f", "format.yaml", "Specify the configure file for formatting chunkfile pool")
 	flags.BoolVar(&options.showStatus, "status", false, "Show formatting status")
 	flags.BoolVar(&options.stopFormat, "stop", false, "Stop formatting progress")
+	flags.BoolVar(&options.debug, "debug", false, "Debug formatting progress")
+	flags.BoolVar(&options.cleanFormat, "clean", false, "Clean the Container")


caoxianfei1 · 2023-10-07T08:08:45Z

cli/command/format.go

+	showStatus  := options.showStatus
+	stopFormat  := options.stopFormat
+	debug       := options.debug
+	cleanFormat := options.cleanFormat


caoxianfei1 · 2023-10-07T08:33:16Z

cli/command/format.go

+	FORMAT_CHUNKFILE_POOL = playbook.FORMAT_CHUNKFILE_POOL
+	GET_FORMAT_STATUS     = playbook.GET_FORMAT_STATUS
+	STOP_FORMAT           = playbook.STOP_FORMAT
+	CLEAN_FORMAT          = playbook.CLEAN_FORMAT


delete it if not used.

Signed-off-by: sjf <[email protected]>

caoxianfei1 · 2023-10-08T01:36:06Z

lgtm.

Wine93

LGTM!

Wine93 added this to the v0.3.0 milestone Aug 28, 2023

Wine93 added the merge to v0.3.0 label Aug 28, 2023

Wine93 self-requested a review August 31, 2023 01:39

Songjf-ttk force-pushed the develop branch from 5d371fd to 9e5add1 Compare August 31, 2023 14:17

Wine93 reviewed Sep 1, 2023

View reviewed changes

cli/command/format.go Outdated

filename string

showStatus bool

stopFormat bool

debugFormat bool

Copy link

Collaborator

Wine93 Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

Wine93 reviewed Sep 1, 2023

View reviewed changes

Songjf-ttk changed the title ~~[feat]CurveadmConfig: add debug mode~~ [WIP][feat]CurveadmConfig: add debug mode Sep 1, 2023

caoxianfei1 added the developer activities label Sep 5, 2023

caoxianfei1 reviewed Sep 15, 2023

View reviewed changes

internal/task/task/checker/network.go Outdated

if debugmode {

glg.Get().SetLevel(glg.DEBG)

return nil, nil

}

Copy link

Contributor

caoxianfei1 Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

caoxianfei1 reviewed Sep 15, 2023

View reviewed changes

Songjf-ttk force-pushed the develop branch from 9e5add1 to a4d4a4c Compare September 18, 2023 01:17

Songjf-ttk changed the title ~~[WIP][feat]CurveadmConfig: add debug mode~~ [feat]CurveadmConfig: add debug mode Sep 18, 2023

Songjf-ttk requested review from Wine93 and caoxianfei1 September 18, 2023 02:18

caoxianfei1 reviewed Sep 18, 2023

View reviewed changes

Songjf-ttk force-pushed the develop branch 2 times, most recently from a96ce9e to 57a1505 Compare September 20, 2023 11:34

Songjf-ttk force-pushed the develop branch 5 times, most recently from 5c0b62e to bec09a1 Compare October 5, 2023 09:05

Songjf-ttk changed the title ~~[feat]CurveadmConfig: add debug mode~~ [feat]Curveadm: add debug mode Oct 5, 2023

Songjf-ttk force-pushed the develop branch 2 times, most recently from 8a96cd6 to 6e53f2d Compare October 5, 2023 14:04

Songjf-ttk requested a review from caoxianfei1 October 5, 2023 14:15

caoxianfei1 reviewed Oct 7, 2023

View reviewed changes

Songjf-ttk force-pushed the develop branch from 6e53f2d to fee8302 Compare October 7, 2023 14:06

[feat]curveadm: add clean command for bs format

68ecc95

Signed-off-by: sjf <[email protected]>

Songjf-ttk force-pushed the develop branch from fee8302 to 68ecc95 Compare October 7, 2023 14:21

Songjf-ttk requested a review from caoxianfei1 October 7, 2023 14:35

caoxianfei1 approved these changes Oct 8, 2023

View reviewed changes

Wine93 approved these changes Oct 8, 2023

View reviewed changes

caoxianfei1 merged commit 14c8166 into opencurve:develop Oct 8, 2023
6 checks passed

caoxianfei1 removed the developer activities label Nov 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat]Curveadm: add debug mode #303

[feat]Curveadm: add debug mode #303

Songjf-ttk commented Aug 28, 2023 •

edited

Loading

Wine93 commented Aug 28, 2023

Songjf-ttk commented Aug 29, 2023 •

edited

Loading

Wine93 Sep 1, 2023

Wine93 Sep 1, 2023

Wine93 Sep 1, 2023

Wine93 Sep 1, 2023

caoxianfei1 Sep 15, 2023

Songjf-ttk Sep 18, 2023

Wine93 Sep 25, 2023

caoxianfei1 Sep 15, 2023

caoxianfei1 Sep 15, 2023

caoxianfei1 Sep 18, 2023

caoxianfei1 commented Sep 20, 2023

caoxianfei1 commented Sep 22, 2023

Songjf-ttk commented Oct 5, 2023

caoxianfei1 commented Oct 7, 2023

caoxianfei1 Oct 7, 2023

Wine93 Oct 7, 2023

caoxianfei1 Oct 7, 2023

caoxianfei1 Oct 7, 2023

caoxianfei1 Oct 7, 2023

caoxianfei1 commented Oct 8, 2023

Wine93 left a comment

[feat]Curveadm: add debug mode #303

[feat]Curveadm: add debug mode #303

Conversation

Songjf-ttk commented Aug 28, 2023 • edited Loading

Wine93 commented Aug 28, 2023

Songjf-ttk commented Aug 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caoxianfei1 commented Sep 20, 2023

caoxianfei1 commented Sep 22, 2023

Songjf-ttk commented Oct 5, 2023

caoxianfei1 commented Oct 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caoxianfei1 commented Oct 8, 2023

Wine93 left a comment

Choose a reason for hiding this comment

Songjf-ttk commented Aug 28, 2023 •

edited

Loading

Songjf-ttk commented Aug 29, 2023 •

edited

Loading