-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize curve-client #88
Conversation
9228d16
to
a7dd153
Compare
@@ -25,93 +25,6 @@ | |||
namespace curve { | |||
namespace common { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件可以直接删掉吧?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
#include "src/client/io_tracker.h" | ||
|
||
// TODO(tongguangxun) :优化重试逻辑,将重试逻辑与RPC返回逻辑拆开 | ||
namespace curve { | ||
namespace client { | ||
ClientClosure::BackoffParam ClientClosure::backoffParam_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个怎么去掉了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有去掉,应该是github显示的问题
@@ -166,9 +168,11 @@ void FileClient::UnInit() { | |||
int FileClient::Open(const std::string& filename, | |||
const UserInfo_t& userinfo, | |||
std::string* sessionId) { | |||
FileInstance* fileserv = GetInitedFileInstance(filename, userinfo, false); | |||
FileInstance* fileserv = FileInstance::NewInitedFileInstance( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这两种写法有什么区别?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
使用上没啥区别,改成放到FileInstance类里面了。
|
||
/** | ||
* 返回给用户或者重新进队的时候都要释放inflight token | ||
* 获取metric指针 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
新加的注释最好都是英文
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这部分注释不是新加的,是调整了一些函数的顺序。
0a4f69d
to
ad782d1
Compare
c735271
to
9d466c0
Compare
9d466c0
to
1f1a2ba
Compare
What problem does this PR solve?
optimization curve-client performance
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List