Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize curve-client #88

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Conversation

wu-hanqing
Copy link
Contributor

@wu-hanqing wu-hanqing commented Sep 8, 2020

What problem does this PR solve?

optimization curve-client performance

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

Sorry, something went wrong.

@wu-hanqing wu-hanqing force-pushed the optim-curve-client branch 3 times, most recently from 9228d16 to a7dd153 Compare September 10, 2020 06:54
@@ -25,93 +25,6 @@
namespace curve {
namespace common {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件可以直接删掉吧?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

#include "src/client/io_tracker.h"

// TODO(tongguangxun) :优化重试逻辑,将重试逻辑与RPC返回逻辑拆开
namespace curve {
namespace client {
ClientClosure::BackoffParam ClientClosure::backoffParam_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个怎么去掉了?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有去掉,应该是github显示的问题

@@ -166,9 +168,11 @@ void FileClient::UnInit() {
int FileClient::Open(const std::string& filename,
const UserInfo_t& userinfo,
std::string* sessionId) {
FileInstance* fileserv = GetInitedFileInstance(filename, userinfo, false);
FileInstance* fileserv = FileInstance::NewInitedFileInstance(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两种写法有什么区别?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用上没啥区别,改成放到FileInstance类里面了。


/**
* 返回给用户或者重新进队的时候都要释放inflight token
* 获取metric指针
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新加的注释最好都是英文

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这部分注释不是新加的,是调整了一些函数的顺序。

@wu-hanqing wu-hanqing force-pushed the optim-curve-client branch 4 times, most recently from 0a4f69d to ad782d1 Compare September 15, 2020 07:10
src/client/iomanager4file.h Outdated Show resolved Hide resolved
src/client/iomanager.h Show resolved Hide resolved
nebd/src/part1/nebd_client.cpp Outdated Show resolved Hide resolved
nebd/src/part1/nebd_client.h Outdated Show resolved Hide resolved
nebd/src/part1/nebd_client.h Show resolved Hide resolved
src/client/client_common.h Show resolved Hide resolved
src/client/chunk_closure.h Show resolved Hide resolved
src/client/chunk_closure.h Show resolved Hide resolved
src/client/chunk_closure.cpp Outdated Show resolved Hide resolved
src/client/chunk_closure.cpp Show resolved Hide resolved
src/client/unstable_helper.cpp Show resolved Hide resolved
src/client/unstable_helper.h Outdated Show resolved Hide resolved
@wu-hanqing wu-hanqing force-pushed the optim-curve-client branch 4 times, most recently from c735271 to 9d466c0 Compare September 23, 2020 12:31
@xu-chaojie xu-chaojie merged commit 97fceea into opencurve:master Sep 24, 2020
@wu-hanqing wu-hanqing deleted the optim-curve-client branch September 24, 2020 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants